Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210210173532.370914-1-xie.he.0141@gmail.com> <f701aad45e35579c8b79836ffeb86ea9@dev.tdt.de>
In-Reply-To: <f701aad45e35579c8b79836ffeb86ea9@dev.tdt.de>
From:   Xie He <xie.he.0141@gmail.com>
Date:   Sun, 14 Feb 2021 23:00:10 -0800
Message-ID: <CAJht_EOrNaavomac8OVv8i0YxMgsX7oWAFDDRUzWTjpNhWpCcg@mail.gmail.com>
Subject: Re: [PATCH net-next RFC v2] net: hdlc_x25: Queue outgoing LAPB frames
To:     Martin Schiller <ms@dev.tdt.de>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Linux X25 <linux-x25@vger.kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Krzysztof Halasa <khc@pm.waw.pl>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Feb 14, 2021 at 10:27 PM Martin Schiller <ms@dev.tdt.de> wrote:
>
> At first glance, the patch looks quite reasonable. The only thing I
> noticed right away is that you also included the changes of your patch
> "Return meaningful error code in x25_open".

Thanks! It was because this patch was sent before that fix got merged
into "net-next". I will drop that part now.

I will also make the MTU of the virtual X.25 device be HDLC_MAX_MTU
(instead of HDLC_MAX_MTU - 2), because I see other HDLC Protocol
Drivers seem to also use this value as MTU (without subtracting the
header length).

> I hope to get back to the office this week and test it.

Thanks!