Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
To:     Dejin Zheng <zhengdejin5@gmail.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "wangzhou1@hisilicon.com" <wangzhou1@hisilicon.com>,
        "ftoth@exalondelft.nl" <ftoth@exalondelft.nl>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "qiuzhenfa@hisilicon.com" <qiuzhenfa@hisilicon.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/3] dmaengine: dw-edma: Add missing call to
 'pci_free_irq_vectors()' in probe function
Thread-Topic: [PATCH 2/3] dmaengine: dw-edma: Add missing call to
 'pci_free_irq_vectors()' in probe function
Thread-Index: AQHXAtRksckgD5i8WEiw8EdykNKVE6pY+qVw
Date:   Mon, 15 Feb 2021 09:45:07 +0000
Message-ID: <DM5PR12MB18357590D1A8C22A1E7287BCDA889@DM5PR12MB1835.namprd12.prod.outlook.com>
References: <20210214132153.575350-1-zhengdejin5@gmail.com>
 <20210214132153.575350-3-zhengdejin5@gmail.com>
In-Reply-To: <20210214132153.575350-3-zhengdejin5@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d93fd70-857a-4ebc-579d-08d8d196614f
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2021 09:45:07.9954
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: clQ4pO5Yf5Kw1Hcy74eTXBEeretxH4+di1jf/GjPNwBpMQfusNSJmR9upbNSQNtQH9FluLh8vkw4LD15otPZog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4484
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Feb 14, 2021 at 13:21:52, Dejin Zheng <zhengdejin5@gmail.com>=20
wrote:

> Call to 'pci_free_irq_vectors()' is missing in the error handling path
> of the probe function, So add it.
>=20
> Fixes: 41aaff2a2ac01c5 ("dmaengine: Add Synopsys eDMA IP PCIe glue-logic"=
)
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> ---
>  drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-=
edma-pcie.c
> index 1eafc602e17e..c1e796bd3ee9 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -185,24 +185,31 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  	/* Validating if PCI interrupts were enabled */
>  	if (!pci_dev_msi_enabled(pdev)) {
>  		pci_err(pdev, "enable interrupt failed\n");
> -		return -EPERM;
> +		err =3D -EPERM;
> +		goto err_free_irq;
>  	}
> =20
>  	dw->irq =3D devm_kcalloc(dev, nr_irqs, sizeof(*dw->irq), GFP_KERNEL);
> -	if (!dw->irq)
> -		return -ENOMEM;
> +	if (!dw->irq) {
> +		err =3D -ENOMEM;
> +		goto err_free_irq;
> +	}
> =20
>  	/* Starting eDMA driver */
>  	err =3D dw_edma_probe(chip);
>  	if (err) {
>  		pci_err(pdev, "eDMA probe failed\n");
> -		return err;
> +		goto err_free_irq;
>  	}
> =20
>  	/* Saving data structure reference */
>  	pci_set_drvdata(pdev, chip);
> =20
>  	return 0;
> +
> +err_free_irq:
> +	pci_free_irq_vectors(pdev);
> +	return err;
>  }
> =20
>  static void dw_edma_pcie_remove(struct pci_dev *pdev)
> --=20
> 2.25.0

Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>