Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 15 Feb 2021 20:46:06 +0800
From:   Dejin Zheng <zhengdejin5@gmail.com>
To:     Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Cc:     "vkoul@kernel.org" <vkoul@kernel.org>,
        "wangzhou1@hisilicon.com" <wangzhou1@hisilicon.com>,
        "ftoth@exalondelft.nl" <ftoth@exalondelft.nl>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "qiuzhenfa@hisilicon.com" <qiuzhenfa@hisilicon.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] dmaengine: dw-edma: Add missing call to
 'pci_free_irq_vectors()' in probe function
Message-ID: <20210215124606.GC618076@nuc8i5>
References: <20210214132153.575350-1-zhengdejin5@gmail.com>
 <20210214132153.575350-3-zhengdejin5@gmail.com>
 <DM5PR12MB18357590D1A8C22A1E7287BCDA889@DM5PR12MB1835.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DM5PR12MB18357590D1A8C22A1E7287BCDA889@DM5PR12MB1835.namprd12.prod.outlook.com>
Precedence: bulk

On Mon, Feb 15, 2021 at 09:45:07AM +0000, Gustavo Pimentel wrote:
> On Sun, Feb 14, 2021 at 13:21:52, Dejin Zheng <zhengdejin5@gmail.com> 
> wrote:
> 
> > Call to 'pci_free_irq_vectors()' is missing in the error handling path
> > of the probe function, So add it.
> > 
> > Fixes: 41aaff2a2ac01c5 ("dmaengine: Add Synopsys eDMA IP PCIe glue-logic")
> > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> > ---
> >  drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++++++++++----
> >  1 file changed, 11 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> > index 1eafc602e17e..c1e796bd3ee9 100644
> > --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> > +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> > @@ -185,24 +185,31 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
> >  	/* Validating if PCI interrupts were enabled */
> >  	if (!pci_dev_msi_enabled(pdev)) {
> >  		pci_err(pdev, "enable interrupt failed\n");
> > -		return -EPERM;
> > +		err = -EPERM;
> > +		goto err_free_irq;
> >  	}
> >  
> >  	dw->irq = devm_kcalloc(dev, nr_irqs, sizeof(*dw->irq), GFP_KERNEL);
> > -	if (!dw->irq)
> > -		return -ENOMEM;
> > +	if (!dw->irq) {
> > +		err = -ENOMEM;
> > +		goto err_free_irq;
> > +	}
> >  
> >  	/* Starting eDMA driver */
> >  	err = dw_edma_probe(chip);
> >  	if (err) {
> >  		pci_err(pdev, "eDMA probe failed\n");
> > -		return err;
> > +		goto err_free_irq;
> >  	}
> >  
> >  	/* Saving data structure reference */
> >  	pci_set_drvdata(pdev, chip);
> >  
> >  	return 0;
> > +
> > +err_free_irq:
> > +	pci_free_irq_vectors(pdev);
> > +	return err;
> >  }
> >  
> >  static void dw_edma_pcie_remove(struct pci_dev *pdev)
> > -- 
> > 2.25.0
> 
> Acked-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> 
>
Gustavo, Thanks!

Dejin