Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 5jBAlANxipkf5eOocuv2V7NkcF7OZIE/Vv3P+XveSSSUDn7wTLp2Nq/FBlFNXR7axhMEGuCrOa
 uwd4xrhq/xMA==
IronPort-SDR: ni4OXckW4L+aJIPdFOZ9pQkZww/w+Syf7XCWV9NFEfkw6YP2EviRHCjcNvYDlLHEuUnsMW7ERK
 jSGAVmIJd+WA==
Date:   Mon, 15 Feb 2021 15:20:40 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Dejin Zheng <zhengdejin5@gmail.com>
Cc:     jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
        wsa@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH i2c-next] i2c: designware: Consolidate
 pci_free_irq_vectors to a single place
Message-ID: <YCp1KL/+YYxmr7vO@smile.fi.intel.com>
References: <20210214064529.481341-1-zhengdejin5@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210214064529.481341-1-zhengdejin5@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote:
> Consolidate pci_free_irq_vectors to a single place using "goto free_irq"
> for simplify the code.

One nit below, after addressing:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

> +free_irq:

It's quite confusing name. I would expect to see here (with current proposal)
*free_irq() call, but no, I don't see a such.

Please, change to something like
	err_pci_free_irq_vectors:
or alternatively
	err_free_irq_vectors:
however I think first one is disambiguous.

> +	pci_free_irq_vectors(pdev);
> +	return r;

-- 
With Best Regards,
Andy Shevchenko