Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210214132153.575350-1-zhengdejin5@gmail.com> <20210214132153.575350-2-zhengdejin5@gmail.com>
In-Reply-To: <20210214132153.575350-2-zhengdejin5@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 15 Feb 2021 15:25:46 +0200
Message-ID: <CAHp75Vdt3j=gXepTfpSimazQZz63F1qwGwooh8jsbYKa6=mntg@mail.gmail.com>
Subject: Re: [PATCH 1/3] dmaengine: hsu: Add missing call to
 'pci_free_irq_vectors()' in probe and remove functions
To:     Dejin Zheng <zhengdejin5@gmail.com>
Cc:     Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Vinod Koul <vkoul@kernel.org>,
        Zhou Wang <wangzhou1@hisilicon.com>,
        Ferry Toth <ftoth@exalondelft.nl>, qiuzhenfa@hisilicon.com,
        dmaengine <dmaengine@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Feb 14, 2021 at 3:22 PM Dejin Zheng <zhengdejin5@gmail.com> wrote:
>
> Call to 'pci_free_irq_vectors()' are missing both in the error handling
> path of the probe function, and in the remove function.
> Add them.

> Fixes: e9bb8a9df316a2 ("dmaengine: hsu: pci: switch to new API for IRQ allocation")

Same as per others. This does not fix anything, because there is no issue.
If you want to have it better, introduce a pcim_alloc_irq_vectors() to
show that it's managed.


-- 
With Best Regards,
Andy Shevchenko