Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: BGY6DJYlDlph3e2TK+3NZCQ6IEZF61tb/6TxUj7hKhlhMPyDhiEZIzn3l8K2kUGMP3i4FygKgf
 HJMJfY93H6Xg==
IronPort-SDR: DIXmMMJmAz3vR9XHDZCRkouf+7yLMNdrRd3hwF38/eCUwr9xCTdKhqATzOI+b0PRNdDIPxpq/4
 IZe7uWHk3GWw==
Date:   Mon, 15 Feb 2021 15:28:48 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Dejin Zheng <zhengdejin5@gmail.com>
Cc:     jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
        wsa@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH i2c-next] i2c: designware: Consolidate
 pci_free_irq_vectors to a single place
Message-ID: <YCp3EGc6N5iMlvfm@smile.fi.intel.com>
References: <20210214064529.481341-1-zhengdejin5@gmail.com>
 <YCp1KL/+YYxmr7vO@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YCp1KL/+YYxmr7vO@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Feb 15, 2021 at 03:20:40PM +0200, Andy Shevchenko wrote:
> On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote:
> > Consolidate pci_free_irq_vectors to a single place using "goto free_irq"
> > for simplify the code.

FYI, you may rather to introduce a pcim_alloc_irq_vectors() and drop all these
calls altogether.

Note to everybody: PCIm is not ideal, but this piece is being called whenever
pcim_enable_device() makes resources manageable. The problem here is the
naming.

-- 
With Best Regards,
Andy Shevchenko