Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: lzTps7Z5axOVXNWefUwjhDbC/z9UIv0h+c9IImMvUgJkuUPN0kkZWdq4Mg6LMQCIealolUF+s3
 7U3ZO7br7YYw==
IronPort-SDR: JP3GDrYHwJVSWw0VW0CVDQX6PFwg51MbXkTFzNTFyAJcEjGfcgei7PyaqumADIaf700t75O7i+
 YJhEFDEoHQQg==
Subject: Re: [PATCHv5 1/7] firmware: stratix10-svc: reset
 COMMAND_RECONFIG_FLAG_PARTIAL to 0
To:     Tom Rix <trix@redhat.com>, mdf@kernel.org,
        gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Richard Gong <richard.gong@intel.com>
References: <1612909233-13867-1-git-send-email-richard.gong@linux.intel.com>
 <1612909233-13867-2-git-send-email-richard.gong@linux.intel.com>
 <bc43e8ab-b8df-fd2f-31e4-02cdc48cadff@redhat.com>
From:   Richard Gong <richard.gong@linux.intel.com>
Message-ID: <3ff3e9ca-cdca-796e-0b57-5010963e7ee1@linux.intel.com>
Date:   Mon, 15 Feb 2021 08:41:01 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <bc43e8ab-b8df-fd2f-31e4-02cdc48cadff@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Tom,

On 2/13/21 9:44 AM, Tom Rix wrote:
> 
> On 2/9/21 2:20 PM, richard.gong@linux.intel.com wrote:
>> From: Richard Gong <richard.gong@intel.com>
>>
>> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
>> aligns with the firmware settings.
>>
>> Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values")
>> Signed-off-by: Richard Gong <richard.gong@intel.com>
>> ---
>> v5: new add, add the missing standalone patch
>> ---
>>   include/linux/firmware/intel/stratix10-svc-client.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
>> index a93d859..f843c6a 100644
>> --- a/include/linux/firmware/intel/stratix10-svc-client.h
>> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
>> @@ -56,7 +56,7 @@
>>    * COMMAND_RECONFIG_FLAG_PARTIAL:
>>    * Set to FPGA configuration type (full or partial).
>>    */
>> -#define COMMAND_RECONFIG_FLAG_PARTIAL	1
>> +#define COMMAND_RECONFIG_FLAG_PARTIAL	0
> 
> Is this the stand alone fix split from v3's patch 1 ?
> 
> https://lore.kernel.org/linux-fpga/YBFW50LPP%2FyEbvEW@kroah.com/
>Yes, it is a stand-alone patch.

> Tom
> 
>>   
>>   /**
>>    * Timeout settings for service clients:
> 
Regards,
Richard