Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5076996pxb; Mon, 15 Feb 2021 08:55:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1C5lw2kTwsAzztGhLvyn1LlIvhiiVnXVngbM/kGEx4mK/2rQCYP13D041T0mfuuzD6222 X-Received: by 2002:a05:6402:1711:: with SMTP id y17mr16391589edu.72.1613408107854; Mon, 15 Feb 2021 08:55:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613408107; cv=none; d=google.com; s=arc-20160816; b=QZl21DjagWIpC7mASW2OrI7+TQZaf8m/XjTMFvWcBV/VKy+pM5s7Sh5GHZhTwXzqwt qbgP92AxAL2qiWhTTwEPsfeZ3A+YKcucVjt9HP5uB99x5bXZP+FVsVRfx+ho6MFqZUl8 vD/LHwQmvXUeExYU08ZzEnmXy9wNH1eQWeRwHjmTpTO7+i//++QRllz+bq3bjzoUIWjx S9mgvgSQgH/3ZzRzTYmk2q/N/W/ldbr4x9FN+ex88L7dP5bvTDCeyZA5tjlqJh5bzFrf wXnxBLY52qR+tDN3foXqXbs48/ppXgxCYzFIV8g9tB0Uu64HCqEhdmA18O6taaXWUfhx eDTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TiO4V8R+FHHu5n9CiZKYfndTDpjyieVFoD3RnKKh1YY=; b=UJNDzD2CGQR2AqFCvV7IoUnMPgo1WvvAePVpMFytZIaev4cNVBNHZznbIgAoVFZ0FF z7dRL222W/FwOFXhJcJrUtaejs6YrxMeM45eIdssKc+yyOfrMfN/8qJPlpX4IyAVhDU1 jk0NO5r3k/bZpNvZaR82xYdVdWwgnuyZnOZqHRt7KaiOModLS7mChupTwLCjYF7Ed0eN N46dIX5IUnZEWqK7zvqMcIFPIYz0DHQ623Wwr7yWgIaptH8T37l3qgQHb3kM6KCbUbRk sAjCj9GPleLFXzu5WcjdPYvivlnScTD9eCbrE4TlNlL/nqhuPBI3tQyBBe0362v50/iv hyPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hkMc36mA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ox9si12799366ejb.242.2021.02.15.08.54.44; Mon, 15 Feb 2021 08:55:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hkMc36mA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231320AbhBOQxd (ORCPT + 99 others); Mon, 15 Feb 2021 11:53:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:50206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231628AbhBOPmX (ORCPT ); Mon, 15 Feb 2021 10:42:23 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 015CB64E64; Mon, 15 Feb 2021 15:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613403310; bh=jlJyYXX2DirVgvnl2l09J3zveDEYwjSFZJkcrTPs2tg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hkMc36mAfHOWUwmcZFKLRmPqj6CWT/PktRWMyH1LL9ydw5W96+HN68YJCWaNIrP3R y8XSCaEiTYLrUOyIJmFMVzyTra2B0JXyJdmYg/ot0/Uza2HgxxPD6FV4Pe8Yn0PpAF BSeGHXhI2h1Mhw98dPKhS4tFdpqLlVrkex/QHnnI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chen-Yu Tsai , Andre Heider , Jernej Skrabec , Maxime Ripard , Sasha Levin Subject: [PATCH 5.10 080/104] drm/sun4i: dw-hdmi: Fix max. frequency for H6 Date: Mon, 15 Feb 2021 16:27:33 +0100 Message-Id: <20210215152722.034930024@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210215152719.459796636@linuxfoundation.org> References: <20210215152719.459796636@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jernej Skrabec [ Upstream commit 1926a0508d8947cf081280d85ff035300dc71da7 ] It turns out that reasoning for lowering max. supported frequency is wrong. Scrambling works just fine. Several now fixed bugs prevented proper functioning, even with rates lower than 340 MHz. Issues were just more pronounced with higher frequencies. Fix that by allowing max. supported frequency in HW and fix the comment. Fixes: cd9063757a22 ("drm/sun4i: DW HDMI: Lower max. supported rate for H6") Reviewed-by: Chen-Yu Tsai Tested-by: Andre Heider Signed-off-by: Jernej Skrabec Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20210209175900.7092-6-jernej.skrabec@siol.net Signed-off-by: Sasha Levin --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c index 23773a5e0650b..bbdfd5e26ec88 100644 --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c @@ -47,11 +47,9 @@ sun8i_dw_hdmi_mode_valid_h6(struct dw_hdmi *hdmi, void *data, { /* * Controller support maximum of 594 MHz, which correlates to - * 4K@60Hz 4:4:4 or RGB. However, for frequencies greater than - * 340 MHz scrambling has to be enabled. Because scrambling is - * not yet implemented, just limit to 340 MHz for now. + * 4K@60Hz 4:4:4 or RGB. */ - if (mode->clock > 340000) + if (mode->clock > 594000) return MODE_CLOCK_HIGH; return MODE_OK; -- 2.27.0