Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5091753pxb; Mon, 15 Feb 2021 09:14:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxrWxMCgVq9yY6NryTr3sDeHXHNX94F7IT9bcBDUy5igfumx6IYygIL2eSyO2W6//Odihuv X-Received: by 2002:a17:907:1692:: with SMTP id hc18mr16650560ejc.244.1613409296707; Mon, 15 Feb 2021 09:14:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613409296; cv=none; d=google.com; s=arc-20160816; b=bAh6URn3TflENRiCgmBoFHUtTV6/s+fpYrCDmstoFPu8/bnlBHqtIb4fuOIclheUDF RzR2U4xVeANeTeKUUWVuS7ty1ui/Qi/Ek6FIitPTCHnNEQaoF5mH6W+Cpy456FWazNI2 q5qE1Jr59HugSk8TfyU2icK1QuKLFg3NlHtilZX5whFgRdSXTOvS6T0+Ffy97USlJHn/ yhAsnywsUFjvOpFmgdR5DoQTGtgqTsPc/U9IrF3JWZBCz8ESFseBzCsV+qyThaOGJd9U Qs3erKPW6su/QG3uV+AjKqIdZja5wXB2RLkF/NE65dH7zyzNxlvcQ0wifeiagEnGpntP Jkiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=1qbgvMVhDrIdBOhWY/750twXaBhB5jXPwXPOmp+AAq4=; b=BMwj3leUj1yDvE0qpyOWhh6918rlhG4rrdmgjT/CgyrcY2l8ws/vt1vEPBOlqf32VH 1VW59wU+NDKw+iVmeNUWy08vBqhx0Tn5+1kz0kjFBW46rypFQZzwLD4M1xa+6oC5t+sN j7jX57wzjoFVNEskJZRz+wT5xH9cSepM0EZGAJ3P3Vhj5ryeGIHiGR+L/J8YCkNb4/4W 5gyl62uJhH1tS8AGyK1LGLrnPTofBXyzhGhFcTFNSDn3IDAHnc28Mkigvl1Qs5Fu7iJ/ Sama+W7a9SrnwZyjfMFF0k9zX21sJj4vtEGUiAbKje4HGndr4TCZ0igrS2pOYrXcFQE5 MMyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si12744092eja.245.2021.02.15.09.14.32; Mon, 15 Feb 2021 09:14:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232490AbhBORMx (ORCPT + 99 others); Mon, 15 Feb 2021 12:12:53 -0500 Received: from mga05.intel.com ([192.55.52.43]:33146 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232091AbhBOQBd (ORCPT ); Mon, 15 Feb 2021 11:01:33 -0500 IronPort-SDR: O5hpvc2A4AQ0VWOvXQfCRBGiK37lI80cxYgoOh/+d6R2I4wCYoZC4WuS1+ywvaaD4xJkXVAN6O ZJINbiTWkYiA== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="267558229" X-IronPort-AV: E=Sophos;i="5.81,181,1610438400"; d="scan'208";a="267558229" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 07:58:55 -0800 IronPort-SDR: qUBcDnMNGWB44uoh1MTupZsdb45fxio3m0E/f9VI6r96twT5vE68fSmGs0x7S+Ia9ZGYH1KBSs erfQ6tr1Worg== X-IronPort-AV: E=Sophos;i="5.81,181,1610438400"; d="scan'208";a="580213026" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 07:58:50 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lBgGs-005GNG-Ra; Mon, 15 Feb 2021 17:58:46 +0200 Date: Mon, 15 Feb 2021 17:58:46 +0200 From: Andy Shevchenko To: Jani Nikula Cc: Alex Deucher , Mikita Lipski , Eryk Brol , Chris Wilson , "David S. Miller" , Rahul Lakkireddy , Francis Laniel , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, netdev@vger.kernel.org, Harry Wentland , Leo Li , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Raju Rangoju , Jakub Kicinski Subject: Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood Message-ID: References: <20210215142137.64476-1-andriy.shevchenko@linux.intel.com> <87y2fpbdmp.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y2fpbdmp.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2021 at 04:37:50PM +0200, Jani Nikula wrote: > On Mon, 15 Feb 2021, Andy Shevchenko wrote: > > We have already few similar implementation and a lot of code that can benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood. > > Good luck. I gave up after just four versions. [1] Thanks for a pointer! I like your version, but here we also discussing a possibility to do something like %py[DOY]. It will consolidate all those RO or whatever sections inside one data structure. > Acked-by: Jani Nikula > > [1] http://lore.kernel.org/r/20191023131308.9420-1-jani.nikula@intel.com -- With Best Regards, Andy Shevchenko