Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5106122pxb; Mon, 15 Feb 2021 09:36:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJyoJs1q4KSOF27nsLzKtLgPgQW59xNrF+4gd6RHUrIPp1aTmLmn6hhyuFmDUJEtOd/FwplW X-Received: by 2002:a17:906:3444:: with SMTP id d4mr16647426ejb.410.1613410603844; Mon, 15 Feb 2021 09:36:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613410603; cv=none; d=google.com; s=arc-20160816; b=IOOzJoFOG8SA2zjyOr6AICGnwBrLsjYwoYKhltjerCDbDU7t/AYxHr1fZba4333JXm VouvavzBAf0xMQSyuz3hemcOdUD0R8GS8xRcWuvWbV6CBGVAn1vMoYmDktsLtzqqPaBx kVF9tmuUkiiBSWJtz4/+D6BlcSfNvifDOlauZ5J6ex2Zd4DzKrUAP9CKFRNUOHdLcipP zvW1gb0tdf3PtAGAzNMOlLB2bz+laMXNag73HOtzz4ZntogYJW31Yh7k8KsMKOL0yR5k eat1m7RGQLN/ensneNelWH5emGTnFq2qOKVrHu7TMVrlBuCWJ8Agmsg7viWM6/+SsuTI utJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=uFzj2rODJUK5q41Mv/Io7SL5b3FYccUSH7ggm3/NT4E=; b=dXNwEFPk5BhFkk/W8kkNzXs4BZQ5hVir3XcKDaDRl/qav6oXAEl3JG5mKCvJ/22ADr 5SCjGYkuRz4uSLXCYkd/kEnL8QJjC8KE2/2dysqocizwSx/5FKkcqapDsAN1wxl4qA0U S3dc7gkjgEN7Pip+D6kL/vOw5NpmNyDkTE9vHqdM3w2ayacELOIQwJssXQy45aUftADY Y3jESUOzE5o33oZ+XlnYIJ+3y/xWSRNG/ffXiOWLa3OniX7iDWvnRpZ675e6V5c3xVro +8M/1Wh9JZAYZk42XhlfOxad+ZkBPbjA0CLtjs0YrJaRBWhPGcxtd3g+0pmCO9MFQ7MJ aapg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X30O2J6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f10si12691921edc.491.2021.02.15.09.36.19; Mon, 15 Feb 2021 09:36:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X30O2J6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232699AbhBORdT (ORCPT + 99 others); Mon, 15 Feb 2021 12:33:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48819 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232100AbhBOQiE (ORCPT ); Mon, 15 Feb 2021 11:38:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613406992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFzj2rODJUK5q41Mv/Io7SL5b3FYccUSH7ggm3/NT4E=; b=X30O2J6iEZVAk3aSzyyBqj867oHhOCjYRcwTf8zOOES0G5DrfamN9Lymv1JVp/nmseHv5p BxsN3HjCz2dREM6sFLhRw/KYqZZZFSdNJJR37onEjzHZZEbkTu9gp2I6x/2Yd6+slpycog yfbz/0eDtCjq8hgI+mtn/Io/QgkW6ck= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-lb4YfMo_NKOUkw2qd-0avg-1; Mon, 15 Feb 2021 11:36:31 -0500 X-MC-Unique: lb4YfMo_NKOUkw2qd-0avg-1 Received: by mail-ed1-f71.google.com with SMTP id g6so5484509edy.9 for ; Mon, 15 Feb 2021 08:36:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uFzj2rODJUK5q41Mv/Io7SL5b3FYccUSH7ggm3/NT4E=; b=bjUbVpM/GoGp+tBkNFvLmH9LAdPVor1YUUUF88QS/PtfjDbPIAaR5xVNT5cG2CNbue PGj45OvJZExAE4p0rsMVP1F8Rwu1HpUAlvxWeb4zTe6GgxHI1j4h3PRn90Ck/i44Eyds yVU5Y4gEpxZuFMnAH2oFuotVDK4LTjX5QDNNiQaCEpcoJJ8lkvceJ0tQPBEQOHoC/byc prVzX63pHDxzFphfy8qeYjr+1ubw7peTGxb5WDhq/joRkB1no0gCr7EDvvKJRuIUGurx 3yS7+3YIwctJvHVqrR3SxLX8QBnmgr7/1bmOmYYJUkvStSTrLUbGqsHjC3T9sfG7cLxT qpQA== X-Gm-Message-State: AOAM531blwmAW6UAdTC41Z4JI9Sm1mFe/PElNeDRj8YpShDPoL+GOe/H 0NJ23HNOHg9srHcrVeZNf3Jev7aDxZ4SdCyrgi+njB7e79jKM6QomYgLdhYCoJN96op6aXiHBk2 cEYZBTo6pnfMM5owDeHJLujuALFt9HWyDL8jSCXEBKhFRci90yCk+oYRQIOHyKcz9ureFJuUgSx 40 X-Received: by 2002:aa7:c991:: with SMTP id c17mr5863068edt.165.1613406989877; Mon, 15 Feb 2021 08:36:29 -0800 (PST) X-Received: by 2002:aa7:c991:: with SMTP id c17mr5863039edt.165.1613406989699; Mon, 15 Feb 2021 08:36:29 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id p16sm10478569edw.44.2021.02.15.08.36.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Feb 2021 08:36:29 -0800 (PST) Subject: Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices To: "Rafael J. Wysocki" Cc: Maximilian Luz , "Rafael J. Wysocki" , Mark Gross , Len Brown , Mark Pearson , Jiaxun Yang , Platform Driver , ACPI Devel Maling List , Linux Kernel Mailing List References: <20210211201703.658240-1-luzmaximilian@gmail.com> <898aa498-8256-d59f-9e72-0e1199b3a62a@redhat.com> <510803ab-b5b8-ce2c-e956-5539874d00bf@redhat.com> From: Hans de Goede Message-ID: <8435cc87-d92f-e1c3-97c7-e2113e0ff3a9@redhat.com> Date: Mon, 15 Feb 2021 17:36:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2/15/21 4:29 PM, Rafael J. Wysocki wrote: > On Mon, Feb 15, 2021 at 4:22 PM Hans de Goede wrote: >> >> Hi, >> >> On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: >>> On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: >>>> >>>> Hi, >>>> >>>> On 2/11/21 9:16 PM, Maximilian Luz wrote: >>>>> This series adds a driver to provide platform profile support on 5th- >>>>> and later generation Microsoft Surface devices with a Surface System >>>>> Aggregator Module. On those devices, the platform profile can be used to >>>>> influence cooling behavior and power consumption. >>>>> >>>>> To achieve this, a new platform profile is introduced: the >>>>> 'balanced-performance' profile. >>>>> >>>>> In addition, a couple of fix-ups are performed: >>>>> - Hide CONFIG_ACPI_PLATFORM_PROFILE and change drivers so that it is >>>>> selected instead of depended on. >>>>> - Fix some references to documentation in a comment. >>>>> >>>>> Note: This series (or more specifically "platform/surface: Add platform >>>>> profile driver") depends on the "platform/surface: Add Surface >>>>> Aggregator device registry" series. >>>>> >>>>> Changes in v2: >>>>> - Introduce new 'balanced-performance' platform profile and change >>>>> profile mapping in driver. >>>>> - Perform some fix-ups for the ACPI platform profile implementation: >>>>> - Fix some references to documentation in a comment. >>>>> - Hide CONFIG_ACPI_PLATFORM_PROFILE >>>> >>>> Thanks, the entire series looks good to me, so for the series: >>>> >>>> Reviewed-by: Hans de Goede >>>> >>>> Rafael, can you (once 5.12-rc1 is out) pick 1-3/4 and then provide a >>>> stable branch for me to merge? >>> >>> Since [1-3/4] appear to be uncontroversial, so IMO it would be better >>> to merge them during the merge window, so they are present in >>> 5.12-rc1. >> >> So I just realized one problem with this plan, patch 1/4 depends >> on (modifies) Kconfig bits which are only in my tree / my 5.12 pull-req >> (which I send out earlier today). > > That should be fine. > > I will be sending the first batch of pull requests tomorrow. Then I > will wait for them to be merged and I will merge the mainline back at > that point. The new patches will be applied on top of that merge, so > if your 5.12 material is included in it, they should build without > problems. Ok, that sounds good to me. Regards, Hans