Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Geethasowjanya Akula <gakula@marvell.com>
To:     Colin Ian King <colin.king@canonical.com>,
        Hariprasad Kelam <hkelam@marvell.com>
CC:     Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXT] re: octeontx2-af: cn10k: MAC internal loopback support
Thread-Topic: [EXT] re: octeontx2-af: cn10k: MAC internal loopback support
Thread-Index: AQHXA7r+IznTpRy3FUeBDGO9GBCZB6pZgO/r
Date:   Mon, 15 Feb 2021 18:01:24 +0000
Message-ID: <DM6PR18MB2602A0EA4AC0123FC5E430B7CD889@DM6PR18MB2602.namprd18.prod.outlook.com>
References: <bbb47971-22f5-9392-fcdc-bdd068883f27@canonical.com>
In-Reply-To: <bbb47971-22f5-9392-fcdc-bdd068883f27@canonical.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 53f4c035-3804-44f7-a5a3-08d8d1dbb56a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2021 18:01:24.3254
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: O9Cyk/2fu9lM5BnTt+ZX5T2NmqQVwDC0c1yonaSLYtj/j/RtJGyPK7hxDdG+2w9oe1G3+yadQLOeu9lsDHWJSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2779
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-02-15_14:2021-02-12,2021-02-15 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Colin,

I have submitted the patch fixing the reported issue to net-next branch.

Thank you,
Geetha.

________________________________________
From: Colin Ian King <colin.king@canonical.com>
Sent: Monday, February 15, 2021 10:22 PM
To: Hariprasad Kelam
Cc: Sunil Kovvuri Goutham; Linu Cherian; Geethasowjanya Akula; Jerin Jacob =
Kollanukkaran; Hariprasad Kelam; Subbaraya Sundeep Bhatta; netdev@vger.kern=
el.org; linux-kernel@vger.kernel.org
Subject: [EXT] re: octeontx2-af: cn10k: MAC internal loopback support

External Email

----------------------------------------------------------------------
Hi,

Static analysis on linux-next today using Coverity found an issue in the
following commit:

commit 3ad3f8f93c81f81d6e28b2e286b03669cc1fb3b0
Author: Hariprasad Kelam <hkelam@marvell.com>
Date:   Thu Feb 11 21:28:34 2021 +0530

    octeontx2-af: cn10k: MAC internal loopback support

The analysis is as follows:

723 static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
724 {
725        struct mac_ops *mac_ops;

   1. var_decl: Declaring variable lmac_id without initializer.

726        u8 cgx_id, lmac_id;
727

   2. Condition !is_cgx_config_permitted(rvu, pcifunc), taking false branch=
.

728        if (!is_cgx_config_permitted(rvu, pcifunc))
729                return -EPERM;
730

    Uninitialized scalar variable (UNINIT)

731        mac_ops =3D get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
732

   Uninitialized scalar variable (UNINIT)
   3. uninit_use_in_call: Using uninitialized value lmac_id when calling
*mac_ops->mac_lmac_intl_lbk.

733        return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
734                                          lmac_id, en);
735 }

Variables cgx_id and lmac_id are no longer being initialized and garbage
values are being passed into function calls.  Originally, these
variables were being initialized with a call to rvu_get_cgx_lmac_id()
but that has now been removed.

Colin