Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
User-Agent: Cyrus-JMAP/3.5.0-alpha0-141-gf094924a34-fm-20210210.001-gf094924a
Mime-Version: 1.0
Message-Id: <e9da5d1f-e614-4749-9ad6-7121f0fbe573@www.fastmail.com>
In-Reply-To: <20210215130334.GM2087@kadam>
References: <20210213092014.29466-1-will+git@drnd.me>
 <20210215130334.GM2087@kadam>
Date:   Mon, 15 Feb 2021 19:30:29 +0100
From:   "William Durand" <will+git@drnd.me>
To:     "Dan Carpenter" <dan.carpenter@oracle.com>
Cc:     "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: fix typo in a function name
Content-Type: text/plain
Precedence: bulk

> On Sat, Feb 13, 2021 at 09:20:14AM +0000, William Durand wrote:
> > Other function names use the verb 'query' so this function should
> > probably use it too and that's what this patch is about. I didn't
> > find any other occurrence and the code compiles.
> > 
> 
> It's really just assumed that the code still compiles afterwards.
> Sometimes, it's hard for me to right commit messages confidently because
> I don't know if static checker bugs affect real life.  But in this case
> I really think the commit message could be written more confidently.
> 
> Please write it like this:
> "There is a typo here where it says "qurey" but "query" was intended."

Thanks Dan, I'll update the commit message shortly and send a new patch.

Will