Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5149605pxb; Mon, 15 Feb 2021 10:48:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJwPiHxZWjY7zty7plIbTktz5s6jSXGsyM2D/2RlJHLCAXseP9zEbizdt0vW0rDdGjnS3Wvu X-Received: by 2002:a17:906:5855:: with SMTP id h21mr246521ejs.552.1613414883854; Mon, 15 Feb 2021 10:48:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613414883; cv=none; d=google.com; s=arc-20160816; b=CPUuZ3QZDJO5C7d5F1dU6C0DbMwsPeb/z3kXpWmylNXwqc4oM6eAPZSscjt19OfkTV kyg1D+mwKbjGWt/fhx2cHAoEwLBJUCPDsfcW2MIqAzYRDr9UJDUvMwmIqXceS/wedl1B bnL53JRC9gNwHEX/dnxBz+uHzsK3mbTbSMi2i2aWF2MoqRsBgFc419WGl1iBxxz3sB5w RoQrluGJCR+IDfngfni3b1U6e0Wpp1xIutUqr2b4Mhz0oL4g/tfoQ1dFT4UJJijSBCsV mDxev1aef/S2zf1HLV9GBGUjGmkzTfVP1YXnd+eu8oJYFNEb/PAMRvHZCL+C7QVJ/Jt7 FUfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=1thRV95wJ/MpkfVTwAdbwdXVYnPmmrkAJjd2JWQvcW8=; b=J40p9UWg26FrVed5AepFgmUF4fE6pjZcDvWGgRB/YW9cux/Lb2mFL02Wn8gjJLT/SU rEUucvwtfjg1DhDdvfHTdKBit/SKQE126cBKKGKEWMzjWRZ4EuRbex8ROOplGID8F5dE hFLOV61GydmemJXZvmTBeRBpGwUgg7zKvycbmrlXdtqf8Ni8aZbPk6sfQfpfN3r0IezS kHVxmBDIBUbY2IzJSCXNf6DkM5s+VF640xycmogJ+tvu9+GM538LCpN8/OgK7vhichr+ gbBlGufmxskYEwxnDfmD0MV/1FVZdWEvO4F1mPNkdwaX0bYEQ58tGxgJbxCN5wNJqEzP +5cA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m5si6928004ejk.585.2021.02.15.10.47.40; Mon, 15 Feb 2021 10:48:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230314AbhBOSq7 (ORCPT + 99 others); Mon, 15 Feb 2021 13:46:59 -0500 Received: from mail-ot1-f51.google.com ([209.85.210.51]:45231 "EHLO mail-ot1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230194AbhBOSlq (ORCPT ); Mon, 15 Feb 2021 13:41:46 -0500 Received: by mail-ot1-f51.google.com with SMTP id o12so6866613ote.12; Mon, 15 Feb 2021 10:41:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1thRV95wJ/MpkfVTwAdbwdXVYnPmmrkAJjd2JWQvcW8=; b=ocvoieRckeACF8ehaHp0g/o2s66VCUO9HJEdhQ01uaoek10c8SsuVwzaPVTyma5I1l 6KAmLBGtSWyaDbwqw2f1/uJoVIlsF7v7Yn+M6SBKFylqni2neDTY7+Mvxagu1kg3Gy7f PdBUjhDRVf87GGGVln/rC0JXgk5viC+y8B4q9Cn9rtSaSL0Ia58l6Fn5mgNWBFPriZDb BxfCwcgsKRUdilbU9SLaskfBj8zUM7I/VCJtmvVbDDxZizHvjX7WtdZM06zbhB1FS9Lb eZ/DbrDPKVy0AKNeWmB1/3bK95ncO3ECP9JO/ZY/GpTkMD9cOvlcoE6MfBUrTaDxTreu Zvxg== X-Gm-Message-State: AOAM533IC7e4cCc+lS4MflcnFGqMlYFjRiby38j8cOHI9Cy6rc6CcRbg 6AYSvGghNYFV/oYJYf1Fx90KkDH+iGKKCxDJzE4= X-Received: by 2002:a9d:a2d:: with SMTP id 42mr12672489otg.321.1613414464899; Mon, 15 Feb 2021 10:41:04 -0800 (PST) MIME-Version: 1.0 References: <20210211201703.658240-1-luzmaximilian@gmail.com> <898aa498-8256-d59f-9e72-0e1199b3a62a@redhat.com> <510803ab-b5b8-ce2c-e956-5539874d00bf@redhat.com> <8435cc87-d92f-e1c3-97c7-e2113e0ff3a9@redhat.com> In-Reply-To: <8435cc87-d92f-e1c3-97c7-e2113e0ff3a9@redhat.com> From: "Rafael J. Wysocki" Date: Mon, 15 Feb 2021 19:40:54 +0100 Message-ID: Subject: Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices To: Hans de Goede Cc: "Rafael J. Wysocki" , Maximilian Luz , "Rafael J. Wysocki" , Mark Gross , Len Brown , Mark Pearson , Jiaxun Yang , Platform Driver , ACPI Devel Maling List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2021 at 5:36 PM Hans de Goede wrote: > > Hi, > > On 2/15/21 4:29 PM, Rafael J. Wysocki wrote: > > On Mon, Feb 15, 2021 at 4:22 PM Hans de Goede wrote: > >> > >> Hi, > >> > >> On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: > >>> On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: > >>>> > >>>> Hi, > >>>> > >>>> On 2/11/21 9:16 PM, Maximilian Luz wrote: > >>>>> This series adds a driver to provide platform profile support on 5th- > >>>>> and later generation Microsoft Surface devices with a Surface System > >>>>> Aggregator Module. On those devices, the platform profile can be used to > >>>>> influence cooling behavior and power consumption. > >>>>> > >>>>> To achieve this, a new platform profile is introduced: the > >>>>> 'balanced-performance' profile. > >>>>> > >>>>> In addition, a couple of fix-ups are performed: > >>>>> - Hide CONFIG_ACPI_PLATFORM_PROFILE and change drivers so that it is > >>>>> selected instead of depended on. > >>>>> - Fix some references to documentation in a comment. > >>>>> > >>>>> Note: This series (or more specifically "platform/surface: Add platform > >>>>> profile driver") depends on the "platform/surface: Add Surface > >>>>> Aggregator device registry" series. > >>>>> > >>>>> Changes in v2: > >>>>> - Introduce new 'balanced-performance' platform profile and change > >>>>> profile mapping in driver. > >>>>> - Perform some fix-ups for the ACPI platform profile implementation: > >>>>> - Fix some references to documentation in a comment. > >>>>> - Hide CONFIG_ACPI_PLATFORM_PROFILE > >>>> > >>>> Thanks, the entire series looks good to me, so for the series: > >>>> > >>>> Reviewed-by: Hans de Goede > >>>> > >>>> Rafael, can you (once 5.12-rc1 is out) pick 1-3/4 and then provide a > >>>> stable branch for me to merge? > >>> > >>> Since [1-3/4] appear to be uncontroversial, so IMO it would be better > >>> to merge them during the merge window, so they are present in > >>> 5.12-rc1. > >> > >> So I just realized one problem with this plan, patch 1/4 depends > >> on (modifies) Kconfig bits which are only in my tree / my 5.12 pull-req > >> (which I send out earlier today). > > > > That should be fine. > > > > I will be sending the first batch of pull requests tomorrow. Then I > > will wait for them to be merged and I will merge the mainline back at > > that point. The new patches will be applied on top of that merge, so > > if your 5.12 material is included in it, they should build without > > problems. > > Ok, that sounds good to me. In fact, my pull requests are ready right now, so I will be sending them shortly, but that doesn\t change the subsequent steps.