Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5480396pxb; Mon, 15 Feb 2021 22:37:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJwzfeDlUEHDXTwas7GVcV6qfvP82D1ZRyl+2HMNapg17fhegczGcFSvqHKfhA2fcjBSkhks X-Received: by 2002:a50:8a90:: with SMTP id j16mr18903810edj.334.1613457477226; Mon, 15 Feb 2021 22:37:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613457477; cv=none; d=google.com; s=arc-20160816; b=ZDPrOgq5SJCKGH9dDgaCmvrml4j01SWUdG/dvF1FYHFX5SHt5p1Yi3dkC3CDjwApn+ 77av2cwQaICe3yJyjitHChHJhS0GoCOJnpRxB1h66Jt0ykjpXqLoiS6vWmBAevCNqQJH sxRrtFyFQqXifyuTHC4TPvrAdAjqzdw9tVHpyHTW64nJ1UAxSXtrPuVs6xdhAsulqEF7 Rb/VQCYvUt2DetgEuiq6oc/kRBqoij9SscGSuyK+OBRocsGyzixUCfR6GnckZO9KOXxg FhfyYGvlfcVmOkKJu+EJVxPeY63/mHoLutIHDdssT6DJf88O3QkgGEiKBfRPW2BsUCHX HdlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=FqzMpvwZcCQN5Gq6DbVg4B9cHhZjsV2fqZ0zJloiuys=; b=NtH1ofJGQw8k3ocuya9OIGUa2Ej21sJmqieA5neQyCsMhnec1Z5tRsWonEkfZQEgK/ vDSS+woVHaXNgoUKt0++B0FDmECDH84iuMNO5KKYXyuDO+gVvePiyuLLBjktcBw9EHwI hXDELXPX33ccSIr5ohxDp3wXhjeC1ZZpGecz9/HLUiE6+XIG4vwlbtgiYtr+lAJIIIpW ya04OYIvY8nI1Bc4yyryanuAO9DRO7INz9ougR/kptrqr6Coo/gGUx1KBANWdUU6K3aK OZkO0cacl3vXBfw1dZ9OwCiieCz/5Jix5GN5oYgu0YL11ZhgM6S9dTbI5FJO7MTUQpYn Z1eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S6+8leB8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si450024ejr.650.2021.02.15.22.37.33; Mon, 15 Feb 2021 22:37:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S6+8leB8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbhBPGc1 (ORCPT + 99 others); Tue, 16 Feb 2021 01:32:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:52042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbhBPGc0 (ORCPT ); Tue, 16 Feb 2021 01:32:26 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6622F64E6B; Tue, 16 Feb 2021 06:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613457104; bh=tmFIlFH2XPFpK0y8fmdWpKw4LK/fkYsPsxpYKw1kOHo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=S6+8leB8+6lqitJwtlhqzaa4dzVWn5JpUnsuAonLW8mEvcLAjwbiymavPZ1h0WHF2 1DAkgVgtE+AtbmRBuCSCcqOYc/peXumX1yUyTEuTgbmux8r4Buq25bkcqHKhMC+ROn enOxByUvW+PJ/kb9fzJqQi0WMHATSEhDHJhtZNE7emUXNsoShz8cwSwF7zz3kIPChE jnQx2lBvXrSUHEnnyHybGcTsn3xroEseOnnO+3xtNh4tjqoHQWhKeMWDLGBCvezZ1f uWSPndEZTHodniqIvL3fVDdGdaZn2rQlPak106T4sU2y2SPWzUEu1HfM6nLtGLFXuM keda5ZFuOWbZQ== Received: by mail-wr1-f42.google.com with SMTP id v15so11675711wrx.4; Mon, 15 Feb 2021 22:31:44 -0800 (PST) X-Gm-Message-State: AOAM531H/MarY6Fi/LS3X8XQhqSqHD1PAvRHhXVx2Vv8OBa9wu5VIxim PQVcglW7d9GtS9urvpjJWECUziHsPuTNgBIJzA== X-Received: by 2002:a17:907:16a4:: with SMTP id hc36mr13796600ejc.127.1613457102006; Mon, 15 Feb 2021 22:31:42 -0800 (PST) MIME-Version: 1.0 References: <20210211113309.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid> In-Reply-To: <20210211113309.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid> From: Chun-Kuang Hu Date: Tue, 16 Feb 2021 14:31:30 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features To: Nicolas Boichat Cc: Andrzej Hajda , Robert Foss , Chun-Kuang Hu , Daniel Vetter , David Airlie , Emil Velikov , Inki Dae , Jernej Skrabec , Jonas Karlman , Joonyoung Shim , Jordan Crouse , Krzysztof Kozlowski , Kyungmin Park , Laurent Pinchart , Linus Walleij , Maarten Lankhorst , Matthias Brugger , Maxime Ripard , Neil Armstrong , Philipp Zabel , Rajendra Nayak , Rikard Falkeborn , Rob Clark , Sam Ravnborg , Sean Paul , Seung-Woo Kim , Thierry Reding , Thomas Zimmermann , Viresh Kumar , Xin Ji , DRI Development , freedreno@lists.freedesktop.org, Linux ARM , linux-arm-msm@vger.kernel.org, linux-kernel , "moderated list:ARM/Mediatek SoC support" , linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Nicolas: Nicolas Boichat =E6=96=BC 2021=E5=B9=B42=E6=9C=8811= =E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=8811:34=E5=AF=AB=E9=81=93=EF= =BC=9A > > Many of the DSI flags have names opposite to their actual effects, > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually > be disabled. Fix this by including _NO_ in the flag names, e.g. > MIPI_DSI_MODE_NO_EOT_PACKET. For Mediatek part, Acked-by: Chun-Kuang Hu > > Signed-off-by: Nicolas Boichat > --- > I considered adding _DISABLE_ instead, but that'd make the > flag names a big too long. > > Generated with: > flag=3DMIPI_DSI_MODE_VIDEO_HFP; git grep $flag | cut -f1 -d':' | \ > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HFP/" {} > flag=3DMIPI_DSI_MODE_VIDEO_HBP; git grep $flag | cut -f1 -d':' | \ > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HBP/" {} > flag=3DMIPI_DSI_MODE_VIDEO_HSA; git grep $flag | cut -f1 -d':' | \ > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HSA/" {} > flag=3DMIPI_DSI_MODE_EOT_PACKET; git grep $flag | cut -f1 -d':' | \ > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_NO_EOT_PACKET/" {} > (then minor format changes) > > drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +- > drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- > drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++-- > drivers/gpu/drm/bridge/tc358768.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++++---- > drivers/gpu/drm/mcde/mcde_dsi.c | 2 +- > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 +- > drivers/gpu/drm/msm/dsi/dsi_host.c | 8 ++++---- > drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c | 2 +- > drivers/gpu/drm/panel/panel-dsi-cm.c | 2 +- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 2 +- > drivers/gpu/drm/panel/panel-khadas-ts050.c | 2 +- > drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- > drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c | 2 +- > drivers/gpu/drm/panel/panel-novatek-nt35510.c | 2 +- > drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 2 +- > drivers/gpu/drm/panel/panel-samsung-s6d16d0.c | 2 +- > drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 2 +- > drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c | 2 +- > drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c | 4 ++-- > drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 2 +- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > drivers/gpu/drm/panel/panel-sony-acx424akp.c | 2 +- > drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +- > include/drm/drm_mipi_dsi.h | 8 ++++---- > 25 files changed, 36 insertions(+), 36 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/b= ridge/adv7511/adv7533.c > index aa19d5a40e31..59d718bde8c4 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c > @@ -165,7 +165,7 @@ int adv7533_attach_dsi(struct adv7511 *adv) > dsi->lanes =3D adv->num_dsi_lanes; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYN= C_PULSE | > - MIPI_DSI_MODE_EOT_PACKET | MIPI_DSI_MODE_VIDEO_= HSE; > + MIPI_DSI_MODE_NO_EOT_PACKET | MIPI_DSI_MODE_VID= EO_HSE; > > ret =3D mipi_dsi_attach(dsi); > if (ret < 0) { > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/= bridge/analogix/anx7625.c > index 65cc05982f82..beecfe6bf359 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1334,7 +1334,7 @@ static int anx7625_attach_dsi(struct anx7625_data *= ctx) > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > - MIPI_DSI_MODE_EOT_PACKET | > + MIPI_DSI_MODE_NO_EOT_PACKET | > MIPI_DSI_MODE_VIDEO_HSE; > > if (mipi_dsi_attach(dsi) < 0) { > diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/c= dns-dsi.c > index 76373e31df92..34aa24269a57 100644 > --- a/drivers/gpu/drm/bridge/cdns-dsi.c > +++ b/drivers/gpu/drm/bridge/cdns-dsi.c > @@ -829,7 +829,7 @@ static void cdns_dsi_bridge_enable(struct drm_bridge = *bridge) > tmp =3D DIV_ROUND_UP(dsi_cfg.htotal, nlanes) - > DIV_ROUND_UP(dsi_cfg.hsa, nlanes); > > - if (!(output->dev->mode_flags & MIPI_DSI_MODE_EOT_PACKET)) > + if (!(output->dev->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)) > tmp -=3D DIV_ROUND_UP(DSI_EOT_PKT_SIZE, nlanes); > > tx_byte_period =3D DIV_ROUND_DOWN_ULL((u64)NSEC_PER_SEC * 8, > @@ -902,7 +902,7 @@ static void cdns_dsi_bridge_enable(struct drm_bridge = *bridge) > tmp =3D readl(dsi->regs + MCTL_MAIN_DATA_CTL); > tmp &=3D ~(IF_VID_SELECT_MASK | HOST_EOT_GEN | IF_VID_MODE); > > - if (!(output->dev->mode_flags & MIPI_DSI_MODE_EOT_PACKET)) > + if (!(output->dev->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)) > tmp |=3D HOST_EOT_GEN; > > if (output->dev->mode_flags & MIPI_DSI_MODE_VIDEO) > diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/t= c358768.c > index 8ed8302d6bbb..320f95ae6077 100644 > --- a/drivers/gpu/drm/bridge/tc358768.c > +++ b/drivers/gpu/drm/bridge/tc358768.c > @@ -825,7 +825,7 @@ static void tc358768_bridge_pre_enable(struct drm_bri= dge *bridge) > if (!(dsi_dev->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)) > val |=3D TC358768_DSI_CONTROL_HSCKMD; > > - if (dsi_dev->mode_flags & MIPI_DSI_MODE_EOT_PACKET) > + if (dsi_dev->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) > val |=3D TC358768_DSI_CONTROL_EOTDIS; > > tc358768_write(priv, TC358768_DSI_CONFW, val); > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/ex= ynos/exynos_drm_dsi.c > index 83ab6b343f51..99249d0da330 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -809,15 +809,15 @@ static int exynos_dsi_init_link(struct exynos_dsi *= dsi) > reg |=3D DSIM_AUTO_MODE; > if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSE) > reg |=3D DSIM_HSE_MODE; > - if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HFP)) > + if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HFP)) > reg |=3D DSIM_HFP_MODE; > - if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HBP)) > + if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HBP)) > reg |=3D DSIM_HBP_MODE; > - if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_HSA)) > + if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HSA)) > reg |=3D DSIM_HSA_MODE; > } > > - if (!(dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET)) > + if (!(dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET)) > reg |=3D DSIM_EOT_DISABLE; > > switch (dsi->format) { > diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_= dsi.c > index 2314c8122992..f4cdc3cfd7d0 100644 > --- a/drivers/gpu/drm/mcde/mcde_dsi.c > +++ b/drivers/gpu/drm/mcde/mcde_dsi.c > @@ -760,7 +760,7 @@ static void mcde_dsi_start(struct mcde_dsi *d) > DSI_MCTL_MAIN_DATA_CTL_BTA_EN | > DSI_MCTL_MAIN_DATA_CTL_READ_EN | > DSI_MCTL_MAIN_DATA_CTL_REG_TE_EN; > - if (d->mdsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET) > + if (d->mdsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) > val |=3D DSI_MCTL_MAIN_DATA_CTL_HOST_EOT_GEN; > writel(val, d->regs + DSI_MCTL_MAIN_DATA_CTL); > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediate= k/mtk_dsi.c > index a1ff152ef468..5c0c9180273a 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -402,7 +402,7 @@ static void mtk_dsi_rxtx_control(struct mtk_dsi *dsi) > } > > tmp_reg |=3D (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) <<= 6; > - tmp_reg |=3D (dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET) >> 3; > + tmp_reg |=3D (dsi->mode_flags & MIPI_DSI_MODE_NO_EOT_PACKET) >> 3= ; > > writel(tmp_reg, dsi->regs + DSI_TXRX_CTRL); > } > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi= /dsi_host.c > index ab281cba0f08..a97a7822e596 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -850,11 +850,11 @@ static void dsi_ctrl_config(struct msm_dsi_host *ms= m_host, bool enable, > if (flags & MIPI_DSI_MODE_VIDEO) { > if (flags & MIPI_DSI_MODE_VIDEO_HSE) > data |=3D DSI_VID_CFG0_PULSE_MODE_HSA_HE; > - if (flags & MIPI_DSI_MODE_VIDEO_HFP) > + if (flags & MIPI_DSI_MODE_VIDEO_NO_HFP) > data |=3D DSI_VID_CFG0_HFP_POWER_STOP; > - if (flags & MIPI_DSI_MODE_VIDEO_HBP) > + if (flags & MIPI_DSI_MODE_VIDEO_NO_HBP) > data |=3D DSI_VID_CFG0_HBP_POWER_STOP; > - if (flags & MIPI_DSI_MODE_VIDEO_HSA) > + if (flags & MIPI_DSI_MODE_VIDEO_NO_HSA) > data |=3D DSI_VID_CFG0_HSA_POWER_STOP; > /* Always set low power stop mode for BLLP > * to let command engine send packets > @@ -909,7 +909,7 @@ static void dsi_ctrl_config(struct msm_dsi_host *msm_= host, bool enable, > DSI_T_CLK_PRE_EXTEND_INC_BY_2_BYTECLK); > > data =3D 0; > - if (!(flags & MIPI_DSI_MODE_EOT_PACKET)) > + if (!(flags & MIPI_DSI_MODE_NO_EOT_PACKET)) > data |=3D DSI_EOT_PACKET_CTRL_TX_EOT_APPEND; > dsi_write(msm_host, REG_DSI_EOT_PACKET_CTRL, data); > > diff --git a/drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c b/drive= rs/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c > index e95bc9f60b3f..44674ebedf59 100644 > --- a/drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c > +++ b/drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c > @@ -302,7 +302,7 @@ static int tm5p5_nt35596_probe(struct mipi_dsi_device= *dsi) > dsi->lanes =3D 4; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BUR= ST | > - MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_EOT_PAC= KET | > + MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_NO_EOT_= PACKET | > MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_L= PM; > > drm_panel_init(&ctx->panel, dev, &tm5p5_nt35596_panel_funcs, > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel= /panel-dsi-cm.c > index af381d756ac1..178abfb1737c 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -571,7 +571,7 @@ static int dsicm_probe(struct mipi_dsi_device *dsi) > dsi->lanes =3D 2; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_CLOCK_NON_CONTINUOUS | > - MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_NO_EOT_PACKET; > dsi->hs_rate =3D ddata->panel_data->max_hs_rate; > dsi->lp_rate =3D ddata->panel_data->max_lp_rate; > > diff --git a/drivers/gpu/drm/panel/panel-elida-kd35t133.c b/drivers/gpu/d= rm/panel/panel-elida-kd35t133.c > index bc36aa3c1123..ae3361ccccd5 100644 > --- a/drivers/gpu/drm/panel/panel-elida-kd35t133.c > +++ b/drivers/gpu/drm/panel/panel-elida-kd35t133.c > @@ -265,7 +265,7 @@ static int kd35t133_probe(struct mipi_dsi_device *dsi= ) > dsi->lanes =3D 1; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BUR= ST | > - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET= ; > > drm_panel_init(&ctx->panel, &dsi->dev, &kd35t133_funcs, > DRM_MODE_CONNECTOR_DSI); > diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm= /panel/panel-khadas-ts050.c > index 8f6ac1a40c31..a3ec4cbdbf7a 100644 > --- a/drivers/gpu/drm/panel/panel-khadas-ts050.c > +++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c > @@ -809,7 +809,7 @@ static int khadas_ts050_panel_probe(struct mipi_dsi_d= evice *dsi) > dsi->lanes =3D 4; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BUR= ST | > - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET= ; > > khadas_ts050 =3D devm_kzalloc(&dsi->dev, sizeof(*khadas_ts050), > GFP_KERNEL); > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers= /gpu/drm/panel/panel-leadtek-ltk050h3146w.c > index ed0d5f959037..a5a414920430 100644 > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c > @@ -593,7 +593,7 @@ static int ltk050h3146w_probe(struct mipi_dsi_device = *dsi) > dsi->lanes =3D 4; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BUR= ST | > - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET= ; > > drm_panel_init(&ctx->panel, &dsi->dev, <k050h3146w_funcs, > DRM_MODE_CONNECTOR_DSI); > diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c b/drivers= /gpu/drm/panel/panel-leadtek-ltk500hd1829.c > index 3c00e4f8f803..21e48923836d 100644 > --- a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c > +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c > @@ -442,7 +442,7 @@ static int ltk500hd1829_probe(struct mipi_dsi_device = *dsi) > dsi->lanes =3D 4; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BUR= ST | > - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET= ; > > drm_panel_init(&ctx->panel, &dsi->dev, <k500hd1829_funcs, > DRM_MODE_CONNECTOR_DSI); > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35510.c b/drivers/gpu/= drm/panel/panel-novatek-nt35510.c > index b9a0e56f33e2..9d9334656803 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt35510.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt35510.c > @@ -899,7 +899,7 @@ static int nt35510_probe(struct mipi_dsi_device *dsi) > dsi->hs_rate =3D 349440000; > dsi->lp_rate =3D 9600000; > dsi->mode_flags =3D MIPI_DSI_CLOCK_NON_CONTINUOUS | > - MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_NO_EOT_PACKET; > > /* > * Every new incarnation of this display must have a unique > diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers= /gpu/drm/panel/panel-osd-osd101t2587-53ts.c > index 45b975dee587..198493a6eb6a 100644 > --- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c > +++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c > @@ -184,7 +184,7 @@ static int osd101t2587_panel_probe(struct mipi_dsi_de= vice *dsi) > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | > MIPI_DSI_MODE_VIDEO_BURST | > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > - MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_NO_EOT_PACKET; > > osd101t2587 =3D devm_kzalloc(&dsi->dev, sizeof(*osd101t2587), GFP= _KERNEL); > if (!osd101t2587) > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c b/drivers/gpu/= drm/panel/panel-samsung-s6d16d0.c > index 4aac0d1573dd..b04b9975e9b2 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6d16d0.c > @@ -186,7 +186,7 @@ static int s6d16d0_probe(struct mipi_dsi_device *dsi) > */ > dsi->mode_flags =3D > MIPI_DSI_CLOCK_NON_CONTINUOUS | > - MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_NO_EOT_PACKET; > > s6->supply =3D devm_regulator_get(dev, "vdd1"); > if (IS_ERR(s6->supply)) > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c b/drivers/g= pu/drm/panel/panel-samsung-s6e63j0x03.c > index b962c817fb30..ccc8ed6fe3ae 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c > @@ -446,7 +446,7 @@ static int s6e63j0x03_probe(struct mipi_dsi_device *d= si) > > dsi->lanes =3D 1; > dsi->format =3D MIPI_DSI_FMT_RGB888; > - dsi->mode_flags =3D MIPI_DSI_MODE_EOT_PACKET; > + dsi->mode_flags =3D MIPI_DSI_MODE_NO_EOT_PACKET; > > ctx->supplies[0].supply =3D "vdd3"; > ctx->supplies[1].supply =3D "vci"; > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c b/drivers/= gpu/drm/panel/panel-samsung-s6e63m0-dsi.c > index eec74c10ddda..77289967d3e5 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0-dsi.c > @@ -97,7 +97,7 @@ static int s6e63m0_dsi_probe(struct mipi_dsi_device *ds= i) > dsi->hs_rate =3D 349440000; > dsi->lp_rate =3D 9600000; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | > - MIPI_DSI_MODE_EOT_PACKET | > + MIPI_DSI_MODE_NO_EOT_PACKET | > MIPI_DSI_MODE_VIDEO_BURST; > > ret =3D s6e63m0_probe(dev, s6e63m0_dsi_dcs_read, s6e63m0_dsi_dcs_= write, > diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c b/drivers/gpu/= drm/panel/panel-samsung-s6e8aa0.c > index 527371120266..9b3599d6d2de 100644 > --- a/drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c > +++ b/drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c > @@ -990,8 +990,8 @@ static int s6e8aa0_probe(struct mipi_dsi_device *dsi) > dsi->lanes =3D 4; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BUR= ST > - | MIPI_DSI_MODE_VIDEO_HFP | MIPI_DSI_MODE_VIDEO_HBP > - | MIPI_DSI_MODE_VIDEO_HSA | MIPI_DSI_MODE_EOT_PACKET > + | MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP > + | MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKE= T > | MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_AUTO_VE= RT; > > ret =3D s6e8aa0_parse_dt(ctx); > diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gp= u/drm/panel/panel-sharp-ls043t1le01.c > index 16dbf0f353ed..b937e24dac8e 100644 > --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c > +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c > @@ -282,7 +282,7 @@ static int sharp_nt_panel_probe(struct mipi_dsi_devic= e *dsi) > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | > MIPI_DSI_MODE_VIDEO_HSE | > MIPI_DSI_CLOCK_NON_CONTINUOUS | > - MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_NO_EOT_PACKET; > > sharp_nt =3D devm_kzalloc(&dsi->dev, sizeof(*sharp_nt), GFP_KERNE= L); > if (!sharp_nt) > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index 4e2dad314c79..babc7a7f6844 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -4745,7 +4745,7 @@ static const struct panel_desc_dsi osd101t2045_53ts= =3D { > }, > .flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > - MIPI_DSI_MODE_EOT_PACKET, > + MIPI_DSI_MODE_NO_EOT_PACKET, > .format =3D MIPI_DSI_FMT_RGB888, > .lanes =3D 4, > }; > diff --git a/drivers/gpu/drm/panel/panel-sony-acx424akp.c b/drivers/gpu/d= rm/panel/panel-sony-acx424akp.c > index 065efae213f5..6b706cbf2f9c 100644 > --- a/drivers/gpu/drm/panel/panel-sony-acx424akp.c > +++ b/drivers/gpu/drm/panel/panel-sony-acx424akp.c > @@ -450,7 +450,7 @@ static int acx424akp_probe(struct mipi_dsi_device *ds= i) > else > dsi->mode_flags =3D > MIPI_DSI_CLOCK_NON_CONTINUOUS | > - MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_NO_EOT_PACKET; > > acx->supply =3D devm_regulator_get(dev, "vddi"); > if (IS_ERR(acx->supply)) > diff --git a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c b/drivers/g= pu/drm/panel/panel-xinpeng-xpp055c272.c > index 55172d63a922..d17aae8b71d7 100644 > --- a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > +++ b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > @@ -311,7 +311,7 @@ static int xpp055c272_probe(struct mipi_dsi_device *d= si) > dsi->lanes =3D 4; > dsi->format =3D MIPI_DSI_FMT_RGB888; > dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BUR= ST | > - MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_EOT_PACKET; > + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET= ; > > drm_panel_init(&ctx->panel, &dsi->dev, &xpp055c272_funcs, > DRM_MODE_CONNECTOR_DSI); > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 360e6377e84b..ba91cf22af51 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -119,15 +119,15 @@ struct mipi_dsi_host *of_find_mipi_dsi_host_by_node= (struct device_node *node); > /* enable hsync-end packets in vsync-pulse and v-porch area */ > #define MIPI_DSI_MODE_VIDEO_HSE BIT(4) > /* disable hfront-porch area */ > -#define MIPI_DSI_MODE_VIDEO_HFP BIT(5) > +#define MIPI_DSI_MODE_VIDEO_NO_HFP BIT(5) > /* disable hback-porch area */ > -#define MIPI_DSI_MODE_VIDEO_HBP BIT(6) > +#define MIPI_DSI_MODE_VIDEO_NO_HBP BIT(6) > /* disable hsync-active area */ > -#define MIPI_DSI_MODE_VIDEO_HSA BIT(7) > +#define MIPI_DSI_MODE_VIDEO_NO_HSA BIT(7) > /* flush display FIFO on vsync pulse */ > #define MIPI_DSI_MODE_VSYNC_FLUSH BIT(8) > /* disable EoT packets in HS mode */ > -#define MIPI_DSI_MODE_EOT_PACKET BIT(9) > +#define MIPI_DSI_MODE_NO_EOT_PACKET BIT(9) > /* device supports non-continuous clock behavior (DSI spec 5.6.1) */ > #define MIPI_DSI_CLOCK_NON_CONTINUOUS BIT(10) > /* transmit data in low power */ > -- > 2.30.0.478.g8a0d178c01-goog >