Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210213011624.251838-1-robh@kernel.org>
In-Reply-To: <20210213011624.251838-1-robh@kernel.org>
From:   Michal Simek <monstr@monstr.eu>
Date:   Tue, 16 Feb 2021 07:44:17 +0100
Message-ID: <CAHTX3dJfQffgPt5odNrCnJ2MFd=GVK+NcGsdjbGA_ED_LAwWuw@mail.gmail.com>
Subject: Re: [PATCH] microblaze: Fix built-in DTB alignment to be 8-byte aligned
To:     Rob Herring <robh@kernel.org>
Cc:     DTML <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Guenter Roeck <linux@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

so 13. 2. 2021 v 2:16 odes=C3=ADlatel Rob Herring <robh@kernel.org> napsal:
>
> Commit 79edff12060f ("scripts/dtc: Update to upstream version
> v1.6.0-51-g183df9e9c2b9") broke booting on Microblaze systems depending o=
n
> the build. The problem is libfdt gained an 8-byte starting alignment chec=
k,
> but the Microblaze built-in DTB area is only 4-byte aligned. This affecte=
d
> not just built-in DTBs as bootloader passed DTBs are copied into the
> built-in DTB region.
>
> Other arches using built-in DTBs use a common linker macro which has
> sufficient alignment.
>
> Fixes: 79edff12060f ("scripts/dtc: Update to upstream version v1.6.0-51-g=
183df9e9c2b9")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> Cc: Michal Simek <monstr@monstr.eu>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> As the commit is in my tree, I'll take this via the DT tree.
>
>  arch/microblaze/kernel/vmlinux.lds.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/kernel/vmlinux.lds.S b/arch/microblaze/kerne=
l/vmlinux.lds.S
> index df07b3d06cd6..fb31747ec092 100644
> --- a/arch/microblaze/kernel/vmlinux.lds.S
> +++ b/arch/microblaze/kernel/vmlinux.lds.S
> @@ -45,7 +45,7 @@ SECTIONS {
>                 _etext =3D . ;
>         }
>
> -       . =3D ALIGN (4) ;
> +       . =3D ALIGN (8) ;
>         __fdt_blob : AT(ADDR(__fdt_blob) - LOAD_OFFSET) {
>                 _fdt_start =3D . ;                /* place for fdt blob *=
/
>                 *(__fdt_blob) ;                 /* Any link-placed DTB */
> --
> 2.27.0
>

Applied.

Thanks,
Michal


--=20
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs