DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:Received:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=dHeoxDaWbYn7qVFgWsKYss9X/UnEWYjE6ePUvSjifOWTNFJR64Y0XzprbyeAqcyHl/4n1afFP9nqqkTjKZ+frOUQFwjzX3rUuiv6hH3EAq9njRHoG9+yAuX4FZGmvj7+oiUuzUFFms7yXBiyaikKA7ASRa6nPwyq+IE2hycaPqo=  ;
Message-ID: <20060925171634.69667.qmail@web31809.mail.mud.yahoo.com>
Date: Mon, 25 Sep 2006 10:16:34 -0700 (PDT)
From: Luben Tuikov <ltuikov@yahoo.com>
Reply-To: ltuikov@yahoo.com
Subject: Re: [PATCH] fix idiocy in asd_init_lseq_mdp()
To: dougg@torque.net, Al Viro <viro@ftp.linux.org.uk>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <4517EBF7.4020508@torque.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 869
Lines: 25

--- Douglas Gilbert <dougg@torque.net> wrote:
> Al Viro wrote:
> > To whoever had written that code:
> > 
> > a) priority of >> is higher than that of &
> > b) priority of typecast is higher than that of any binary operator
> > c) learn the fscking C
[...]
> BTW Luben was pointing out that the call you patched
> and the following call can be combined into a less
> trouble prone asd_write_reg_dword() call.

More than that -- I looked at the history of that
file/line and the code as I had written it _never_ had
that broken cast and shift mess.

"Someone" changed that after I submitted the code to lkml/lsml.

    Luben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/