Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5494078pxb; Mon, 15 Feb 2021 23:07:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9g4H3ANOAJf3KclMtBZtOId8t1vcGtIZHP+sjbaOr57hrdIs0XIJUBT8uvCtXV9zvaMrn X-Received: by 2002:a50:ee0e:: with SMTP id g14mr17818851eds.159.1613459256989; Mon, 15 Feb 2021 23:07:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613459256; cv=none; d=google.com; s=arc-20160816; b=Gn6vDWxW6Smze0FRfMBoRkjHcsp+BF5tZibnXJptQ4cEuBYmq5eolElHqms1traP25 b2KVn7VvOtBvFGU/9bdqmsCbwT7OZbxNWR79Nce6uIoJgWRchty2JW5M0XILyKAxs3m/ AXEwbDDWzb4XeLl4j1Igu2VfnxyUCJEES5jHsiu1V+ooCsEXhT9X1HFRYZCvJY75Vr6c zcXKG3tg+8FOZVlh5ic9NG3LOBoUk5z16/ePuuuCxGVwwzollPozpVtmLGh90XrERy66 QwUioH4r/n6zoCHt+y7fmogNSOCjxPeARKodX7ci3W8MAV0xUnc0LkXJw2eMkipWBMxo uuxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=1hSt3wBVRzL1X2DnMZ20N61Zl1K47ziXTYF+NXq/lH0=; b=gKV9tTA4PUe6iYs2jYg1b06EHZL2T5cwbl5sEYsK3BJra1VGNTHxM2z6fJA0BrZqC7 05QthHMeScMiBFio+fkNL0KjMSBiegKEorsykr+EZj2R6sesytNgYDJsiCD5JDz17Z1E L1yTsbnCqBe88xAb8ihlGFYNkMCcEmPNyhIzfOmoiO1f+YwjI5RUvWh7/+NDTECIH/WJ xkXZAEBAkBJlCYGW9/8be7OvZ0FIXStbDeEyzDRCnmz7iG5mMxf62YrcFObIKFEq1weP H3OoS9/p1IJ39xLUk6FK6yFg+zwXNekmwPMCHjr6P6C3jy5G5nPE6HRG9viAUex6k9Sx 1RFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=KAQW9tyg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb13si16526989edb.465.2021.02.15.23.07.14; Mon, 15 Feb 2021 23:07:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=KAQW9tyg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbhBPHE2 (ORCPT + 99 others); Tue, 16 Feb 2021 02:04:28 -0500 Received: from z11.mailgun.us ([104.130.96.11]:54029 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbhBPHE0 (ORCPT ); Tue, 16 Feb 2021 02:04:26 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1613459043; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=1hSt3wBVRzL1X2DnMZ20N61Zl1K47ziXTYF+NXq/lH0=; b=KAQW9tygRIoAdWNAZZIUxcr0RnwvtcMH/mz3ZBF0CZ99kcAB5DcuzmsezkrMxdAnNj2AlsSN MG9rxrx1JKUAitT9AwY+Qvc2P7XYsum4d1b+zgzbzqOvLNfOIHO0ESpTg4Dz0GGKNXejv0JV YgAmgquGCgDfhWfAIQzCcKFSGJM= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 602b6e4981f6c45dce16c55f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 16 Feb 2021 07:03:37 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D138BC43463; Tue, 16 Feb 2021 07:03:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4EC34C433C6; Tue, 16 Feb 2021 07:03:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4EC34C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference From: Kalle Valo In-Reply-To: <43ed9abb9e8d7112f3cc168c2f8c489e253635ba.1613090339.git.skhan@linuxfoundation.org> References: <43ed9abb9e8d7112f3cc168c2f8c489e253635ba.1613090339.git.skhan@linuxfoundation.org> To: Shuah Khan Cc: davem@davemloft.net, kuba@kernel.org, Shuah Khan , ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210216070336.D138BC43463@smtp.codeaurora.org> Date: Tue, 16 Feb 2021 07:03:36 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Shuah Khan wrote: > ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() > return pointer (sta) outside null check. Fix it by moving the code > block under the null check. > > This problem was found while reviewing code to debug RCU warn from > ath10k_wmi_tlv_parse_peer_stats_info() and a subsequent manual audit > of other callers of ieee80211_find_sta_by_ifaddr() that don't hold > RCU read lock. > > Signed-off-by: Shuah Khan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a56c14bb21b2 ath9k: fix ath_tx_process_buffer() potential null ptr dereference -- https://patchwork.kernel.org/project/linux-wireless/patch/43ed9abb9e8d7112f3cc168c2f8c489e253635ba.1613090339.git.skhan@linuxfoundation.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches