Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5543590pxb; Tue, 16 Feb 2021 00:51:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJyD9ahCvMNY64vvE76rO5R52wQbYIWBfN4pOFzSV2M/JjzgtU5+6r+iMCn57TqcwR8FAz4y X-Received: by 2002:a50:f096:: with SMTP id v22mr9822609edl.275.1613465519019; Tue, 16 Feb 2021 00:51:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613465519; cv=none; d=google.com; s=arc-20160816; b=e792q51ltX+SOd/ceKMfHlLRSSlSkHnxlG3lTohtErl/rCJzACZzax4BzIxrNirD8j Az0q+yQuFHP4ephgYEwOt9Wz1UvO3xblvLIBz8OH/b6ht4/I6Dsb/F9uHiEZfLkNeb80 6SULS9p+dAT5PP3sdNvEiOugNqntATKpZ3gXf7dcNuqr16guoGb3I9eNBbGmppVSwNHu kkrQelHjmxFVYKblQoNfimLszIbGpEWQkcfMp9ZWFfr6SkG59aFuU0Ayb75HuCWH4jub eFhw7OEB3QgvzeaSdep+uxXtFadsz1v70O8phRwRvPDJWf4mnPl/TGkr5TNOVXVAdnDA jBYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=HEfjNBv9A0IeCGH2lBEXFixsrQUku1PSnizd+qIdHC4=; b=vnYYbNqGVGPXEHqxOMioF4FlaghnCiLEA1YnW/A6LQ5Lb0UrRzlibXRdPv4Zm9iqTG pfBg2eSE+i5Q8zuz6LxcdZE8KM4bFDhvTeCdAcsv6xO7dyLh0Cfk8y9WJ6lm3YKIvW6B cwaxR7eyWSReLGlvwoE/e4CstyM75FdwimtY8iFDb/7n+sRc8BZM5wfZ6BdgBoKh11wJ IR1vBNVlP1y9gSYOQNHOManRX3h61kuD2RM3Pwq/mwMy8GHU5fbx7tN61a1RuWd44i0m Azu7hWdoSCKByrdPZve1WYMMExqRR1SE7Zogqwe+T0DNeUdi5/MaWzOheKGkZAUWcefH jL0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qo25si439760ejb.288.2021.02.16.00.51.35; Tue, 16 Feb 2021 00:51:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbhBPItL (ORCPT + 99 others); Tue, 16 Feb 2021 03:49:11 -0500 Received: from verein.lst.de ([213.95.11.211]:40382 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbhBPItI (ORCPT ); Tue, 16 Feb 2021 03:49:08 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 2302E6736F; Tue, 16 Feb 2021 09:48:26 +0100 (CET) Date: Tue, 16 Feb 2021 09:48:25 +0100 From: Christoph Hellwig To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , David Howells , Al Viro , linux-fsdevel@vger.kernel.org, Christian Brauner , "David P . Quigley" , James Morris Subject: Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns Message-ID: <20210216084825.GA23845@lst.de> References: <20210216042929.8931-1-rdunlap@infradead.org> <20210216042929.8931-2-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210216042929.8931-2-rdunlap@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote: > Fix kernel-doc warning in libfs.c. > > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not described in 'simple_setattr' Shouldn't the subject say simple_setattr instead of mnt_userns? Otherwise looks good: Reviewed-by: Christoph Hellwig