Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5571000pxb; Tue, 16 Feb 2021 01:46:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQWciz0M2asO/N/BmUveCdyAiF7UmQ0gRCDGCdxgJp/8XMsq2AsNnmsLZpF1Ou9iMTdpjI X-Received: by 2002:a17:906:b055:: with SMTP id bj21mr19865938ejb.355.1613468774114; Tue, 16 Feb 2021 01:46:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613468774; cv=none; d=google.com; s=arc-20160816; b=vizp6Z1s91He959gXrX14rE0hoD3j58AsQ17NlDheVpMFbxR6yJjaqRRZYNQpih0rn 1VxyviuV1Z0uB8V3xlIMhN8VC9f1sE/fHbhKJTSuvBSdLE2mxx9Vl4HDsnMpbaddm5px RniyZOUL7p+zoRw2u+SIH8RPWYbNB0AcRTsNqb4Wq9ZrrB8psxum0/FuGlTX6t4a7ppg zqAf8giD5t3sIdjZzRyZFjSDNK1RqoO9+t68MNjnwiKz52ezHtDJ+ZDOg0kgfeDiHTfv z9tyd+jEVlSLHvBAHd6OKcBZQtNF2Jj24nvtDHcRL3YwLRh1r5YJtIJ5d0rSq2Sopmst FkOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=r/1Y2vMAP+as/Lsg3b51MF4hpfbVC/mT0RnNC5Fm9f0=; b=ywAJsm9hEDrjke4+q7Zm0Gh7c8T/3S+F0n0yt3fgGn9jiOCRGnN8jlaziVRA1iYhl1 13Bdo12ylDzRiX5C5KNngI41fhUFQ7tbtUypA0C6K9CT34FusYu7xF/zL4LrtIzlT9Pa TRYA92bhzZO2U7uzMrdlUfpNVMu26KLdABYP84IDJUyeH/8/9e20MvV793E7wAmKbSAh WNWtYwRNMw4IRElrx0PM12PaG02Z/OcU0+5vIsXrtOh2GtH0ot1MKT5DcodmKOyEXal+ NJYPpH4RoNZcLPiP8DWlxDitBTtC5IX46lTm4998IJSFdzWIm7HvU7kie0kN08ZmA3tY TvcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r23si11964074edy.410.2021.02.16.01.45.50; Tue, 16 Feb 2021 01:46:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbhBPJmt (ORCPT + 99 others); Tue, 16 Feb 2021 04:42:49 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:44349 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbhBPJms (ORCPT ); Tue, 16 Feb 2021 04:42:48 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lBwrn-0007fR-VI; Tue, 16 Feb 2021 09:42:00 +0000 Date: Tue, 16 Feb 2021 10:41:59 +0100 From: Christian Brauner To: Christoph Hellwig Cc: Randy Dunlap , linux-kernel@vger.kernel.org, David Howells , Al Viro , linux-fsdevel@vger.kernel.org, "David P . Quigley" , James Morris Subject: Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns Message-ID: <20210216094159.b4hmjsmkvvrjhdcg@wittgenstein> References: <20210216042929.8931-1-rdunlap@infradead.org> <20210216042929.8931-2-rdunlap@infradead.org> <20210216084825.GA23845@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210216084825.GA23845@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2021 at 09:48:25AM +0100, Christoph Hellwig wrote: > On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote: > > Fix kernel-doc warning in libfs.c. > > > > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not described in 'simple_setattr' > > Shouldn't the subject say simple_setattr instead of mnt_userns? > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig Just an fyi, Lukas sent a series for this 1 or 2 weeks ago https://lore.kernel.org/lkml/20210204180059.28360-1-lukas.bulwahn@gmail.com Hadn't yet replied to that one. Christian