Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5589694pxb; Tue, 16 Feb 2021 02:24:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJz/kbmFXo2YyaZp6spjVNTubKq/1huxs7+RDZmv6rbF40bzue0Wun3hkxvWdcm0eJ5VYg2S X-Received: by 2002:a50:aade:: with SMTP id r30mr19723043edc.15.1613471087921; Tue, 16 Feb 2021 02:24:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613471087; cv=none; d=google.com; s=arc-20160816; b=IjCzrMhAJGhevoZ9PzSfRMQOfo9XqSwyoyB7cF/1HzWbmbSrNsJKlaCFli4bUnppAB WgSK930gGRt57p+EncK4rWGpgIntd9bp1gHdGP4Adj7F5VM+RN+/y/wcxn2ken0VH5J0 eEvYVOlblsAOgQZtxvXpg5tym+B4uxvKmRwvwzDGAFuRHkyjjPAXhlgdh735Aq/YjG4d VH4+WACy3yLqtWBVfCXlr4UHSZPqRWhfrOHfhYo1ixr1CH3BASy3c7k4sdIUj2dfvUYH j0tJ2vexBYW7Z6TL+Xck5O88M772+kpWzKic8HB3TzmEKRWNYM/K9eI7gz+oK1CP/9kd RAHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=U5MwHTSqqXI5EHEsGiuw6S6hSNDVI6DacBvWsR5KJCY=; b=o5XEJ5Y2heHaW7btdbiROlnT+1rJITbGpN/b3K1MJiJqM5glQZACeFvSvDvXZKDimm 532N24L/xyvXg0K1lI0OiyPpBOQyhyATEayu03NbCIbpXlgTt8Fr1ir6WV43DyyGw2d9 SIKz/0kopYNmGh6wOdcv01IjcoE1NdmAMYXpwgc+dhAUvdL+4cAUhWOJpPHxZS+3Rnw2 j2xSERZG4kS5PhoFvXx1utI/0wDN2l+rrbwytvsadJb27Wtfk59gCHQsXNMgYB+8/blY ZVJqI0mC22gsoGEP8CTBpkZsw54Axd/cOalUNrVSTxJUPmKep3tmSlfDBhfz4TN5eng/ pe3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si13654230edi.542.2021.02.16.02.24.24; Tue, 16 Feb 2021 02:24:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbhBPKVb (ORCPT + 99 others); Tue, 16 Feb 2021 05:21:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbhBPKVV (ORCPT ); Tue, 16 Feb 2021 05:21:21 -0500 X-Greylist: delayed 81541 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 16 Feb 2021 02:19:35 PST Received: from hillosipuli.retiisi.eu (hillosipuli.retiisi.eu [IPv6:2a01:4f9:c010:4572::81:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02F65C061574; Tue, 16 Feb 2021 02:19:35 -0800 (PST) Received: from lanttu.localdomain (lanttu-e.localdomain [192.168.1.64]) by hillosipuli.retiisi.eu (Postfix) with ESMTP id 297AA634CA1; Tue, 16 Feb 2021 12:18:30 +0200 (EET) From: Sakari Ailus To: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org, Petr Mladek , Dave Stevenson , hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, Sergey Senozhatsky , Steven Rostedt , Joe Perches , Jani Nikula , Rasmus Villemoes , Daniel Vetter , Thomas Zimmermann Subject: [PATCH v8 4/4] drm: Remove drm_get_format_name() Date: Tue, 16 Feb 2021 12:19:31 +0200 Message-Id: <20210216101931.2110-5-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210216101931.2110-1-sakari.ailus@linux.intel.com> References: <20210216101931.2110-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The %p4cc printk format modifier was recently added to print fourcc codes, replacing drm_get_format_name(). The function is no longer needed, so remove it. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/drm_fourcc.c | 25 ------------------------- include/drm/drm_fourcc.h | 1 - 2 files changed, 26 deletions(-) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 03262472059c..5cf45aa6eedc 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -30,11 +30,6 @@ #include #include -static char printable_char(int c) -{ - return isascii(c) && isprint(c) ? c : '?'; -} - /** * drm_mode_legacy_fb_format - compute drm fourcc code from legacy description * @bpp: bits per pixels @@ -130,26 +125,6 @@ uint32_t drm_driver_legacy_fb_format(struct drm_device *dev, } EXPORT_SYMBOL(drm_driver_legacy_fb_format); -/** - * drm_get_format_name - fill a string with a drm fourcc format's name - * @format: format to compute name of - * @buf: caller-supplied buffer - */ -const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf) -{ - snprintf(buf->str, sizeof(buf->str), - "%c%c%c%c %s-endian (0x%08x)", - printable_char(format & 0xff), - printable_char((format >> 8) & 0xff), - printable_char((format >> 16) & 0xff), - printable_char((format >> 24) & 0x7f), - format & DRM_FORMAT_BIG_ENDIAN ? "big" : "little", - format); - - return buf->str; -} -EXPORT_SYMBOL(drm_get_format_name); - /* * Internal function to query information for a given format. See * drm_format_info() for the public API. diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index 156b122c0ad5..3ea17b8a79d3 100644 --- a/include/drm/drm_fourcc.h +++ b/include/drm/drm_fourcc.h @@ -318,6 +318,5 @@ unsigned int drm_format_info_block_height(const struct drm_format_info *info, int plane); uint64_t drm_format_info_min_pitch(const struct drm_format_info *info, int plane, unsigned int buffer_width); -const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf); #endif /* __DRM_FOURCC_H__ */ -- 2.29.2