Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5629598pxb; Tue, 16 Feb 2021 03:41:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJx/1zPesKiU+H1vFYP2+zjLjzpo3C6JUhUeLd4bkPR7ev+kx3jChYAKEL9dKmWxuKC5aexl X-Received: by 2002:aa7:c0da:: with SMTP id j26mr20275659edp.253.1613475676877; Tue, 16 Feb 2021 03:41:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613475676; cv=none; d=google.com; s=arc-20160816; b=xGpw2EBmo0MaIaw7jg0aalCv5nSmcPDBTG9ycq4iG3pgPGe+Q7qJy5zrSFmrEyoO7O wRajW24B9OMb6TqI9vDerVWpIx8HbwnTDjuJOMT2e4lPV5m0H1swmK6zqD24cjnT/uwR DoGdfH5MfXmIRwo+z5+sOV2Ku4dAHz7F/auoPa9yDe+FmHKMDFeXfECZajfyWz1Z39vp fPS17uTY22Qc7DOVDmjYnqYPM/UfmZfBt4oicvWjVSym5VbeWG39ALDcZ4m9o8WSZnP4 yk1OLGYbrjzOCXcB4K/odvG8kaoadm77q2mEGUvEzuCLmbEwu+ZYFhfgZ/GVfg1TZMQp F6FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1BNcwAgY2lWfqJewfJz+Q3AkCPMKcBiYlzER8aYP8gc=; b=ynp3wkTmfO5RnUXRTnEd3Ys1BfvHA09fSsasqtE7+nK9u3hpt8/K9BICl9TeMy8sfZ 1Z7eyVqnM8mh7akfwI6XzjsWs0r2UHb/E7RSqgUVt3MkFs9CG9j49VqRkjI3mNycvsfn uhOesxqYICR3RgufHqWceYokRvu75pC5bU5cGx94UbtZLsn0enU8Spj2WwkcUR2aYGGZ 3r4tvLvoRWAY87QhqQL4HkySw/CZORKjbwKnWyDJMsus2tyVIwrEJljWVuumgRqphXsL gBlDHDq95QVQNhcuibbyJvlX54FUpjhWJzZ46lbzNJ/KWRCTYmLVVQqrGhSWJqWYvPqf G0Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F5yrq66h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si3947380ejs.186.2021.02.16.03.40.53; Tue, 16 Feb 2021 03:41:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=F5yrq66h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230401AbhBPLjx (ORCPT + 99 others); Tue, 16 Feb 2021 06:39:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48853 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230364AbhBPLi5 (ORCPT ); Tue, 16 Feb 2021 06:38:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613475448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1BNcwAgY2lWfqJewfJz+Q3AkCPMKcBiYlzER8aYP8gc=; b=F5yrq66hVJKQSnsZYO4dDL6cp2sxCiYiwLIMgdX7Cbt2vG3wSXUfH2kNw4GZgY99J6oBTV QB8SsqqVQ6iZmIrbEkJWxq0ZCorfFlz3LYvpkXVyZDRvx5qIHlI6ZugbU/5Lq9+HfjEamV kMm1E55+gvRJ476zXBJXe5UYh/2/7YA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-JoG8JbKEOXqO0suKiZDyqw-1; Tue, 16 Feb 2021 06:37:26 -0500 X-MC-Unique: JoG8JbKEOXqO0suKiZDyqw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6DFEA195D564; Tue, 16 Feb 2021 11:37:25 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1C7D61002382; Tue, 16 Feb 2021 11:37:25 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 47B3F1800634; Tue, 16 Feb 2021 12:37:18 +0100 (CET) From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: Gerd Hoffmann , Dave Airlie , David Airlie , Daniel Vetter , virtualization@lists.linux-foundation.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), spice-devel@lists.freedesktop.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 07/10] drm/qxl: fix prime kmap Date: Tue, 16 Feb 2021 12:37:13 +0100 Message-Id: <20210216113716.716996-8-kraxel@redhat.com> In-Reply-To: <20210216113716.716996-1-kraxel@redhat.com> References: <20210216113716.716996-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the correct kmap variant. We don't have a reservation here, so we can't use the _locked version. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_prime.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_prime.c b/drivers/gpu/drm/qxl/qxl_prime.c index dc295b2e2b52..4aa949799446 100644 --- a/drivers/gpu/drm/qxl/qxl_prime.c +++ b/drivers/gpu/drm/qxl/qxl_prime.c @@ -59,7 +59,7 @@ int qxl_gem_prime_vmap(struct drm_gem_object *obj, struct dma_buf_map *map) struct qxl_bo *bo = gem_to_qxl_bo(obj); int ret; - ret = qxl_bo_kmap_locked(bo, map); + ret = qxl_bo_kmap(bo, map); if (ret < 0) return ret; @@ -71,7 +71,7 @@ void qxl_gem_prime_vunmap(struct drm_gem_object *obj, { struct qxl_bo *bo = gem_to_qxl_bo(obj); - qxl_bo_kunmap_locked(bo); + qxl_bo_kunmap(bo); } int qxl_gem_prime_mmap(struct drm_gem_object *obj, -- 2.29.2