Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5631673pxb; Tue, 16 Feb 2021 03:45:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5Sgj+ARsY+M93Lie9qW4GXEX/4XdidWhQWPEDCiMEcV0gfCqF9Ya2gh1De91gu345njdr X-Received: by 2002:a17:906:a57:: with SMTP id x23mr19699858ejf.40.1613475910586; Tue, 16 Feb 2021 03:45:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613475910; cv=none; d=google.com; s=arc-20160816; b=zXsmG1uF4Wj/3HAEN/LvTr8Gii+YtsaRsgWy5YRJRAvMOKIOx/iXMkTlIR57TZIcLx eamkBG4KiLFsXlMNHmvQNUhrgeDcCQMPdLzL5HZWKJPSNnEZN9hP3AsPkzpTCOL9uLD+ u8TY1rmt1Yw6h7FQS/qVGC6RaktZiuMz+l/DiVhgFyI33xXDZFqht9pop7wmAzu23IZN 2dAo+S3s7Xj8fGwexDTX3rslkZFaiAb7/XSrVy/DkVIG6wsqly8xAbR6jk+LXbelyF6a UJaE5cHg7skkwEjKB/AH6I8FRfiwvY3rlkJN48tS3KVjR9r6ucoQYp3mbP5z5G86rtqU h0jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=7//j7y6xoZuLy2Ngmv+kjotOmXPJtO9KtcN3PXcUSkQ=; b=lbUWpa147KWnrKahdly0CFBqO5G7WWXiwpsX9vj7kTdl7BoWZIbY55R8pE2HnQ+PdI 3grkLwDMbBnoSHgHx+OFw2AOlk3oGvfNV/QLjbpOVjkUmBqyQRWHAMFF+4v6cY5vkTTA 6dbFsmO7oB3RN7T0t7wQY9Et+QQVtpnT5JM/t7d58epE+qXs9cv50S/BL1RHUPKamQSP ASW7vRJ6CZU2Q15nWZhoNq0Zye0eeFr7kmy+RSXuJvu82H8Pt3lExvPePpzfxf4O5WRt ldvWDjeTf7ACo947GLD3YP1Gi7iq2q0FUAFShX5eM3vG0YqKFTGZCCRWexCD/jPRM5bU l4GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=UR4bFjUV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g20si13809376edb.494.2021.02.16.03.44.47; Tue, 16 Feb 2021 03:45:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=UR4bFjUV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230462AbhBPLmp (ORCPT + 99 others); Tue, 16 Feb 2021 06:42:45 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:48343 "EHLO mail-40131.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230378AbhBPLjB (ORCPT ); Tue, 16 Feb 2021 06:39:01 -0500 Date: Tue, 16 Feb 2021 11:38:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1613475495; bh=7//j7y6xoZuLy2Ngmv+kjotOmXPJtO9KtcN3PXcUSkQ=; h=Date:To:From:Cc:Reply-To:Subject:From; b=UR4bFjUVK9exL1LGEM/AUDMtHefnF+AYxkSGYHfIuuTYibotYnneCzbLfSH25ETll 3sZ7j8t0yPcz+LQVqbPQgctzQBPqc/xUMQpD44biUTxn68PXOeAasfYoCI/JmDkirJ Ih+TBLt+inppDmtRCBP/XdqR+G3tn2q2OyuyY7WaUiZiqC/DWbSaZpJCh8Vm9hyaqg LQp5EnEkGVNvacnPk8Pu+Y4TrWLo9gD6Oxxc+yeoQDIMxAxGZkS5uIzcsf4rZPSPTm Rpk1Obtl8HfjPqOdHERYtF5qtMEf10jJqEmtupATBMFpFt/t7G3j8qgczwlCJLfdNA iz5yhj+A6ApaA== To: Magnus Karlsson , =?utf-8?Q?Bj=C3=B6rn_T=C3=B6pel?= From: Alexander Lobakin Cc: "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Paolo Abeni , Eric Dumazet , Xuan Zhuo , Dust Li , Alexander Lobakin , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Reply-To: Alexander Lobakin Subject: [PATCH v4 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit) Message-ID: <20210216113740.62041-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series introduces XSK generic zerocopy xmit by adding XSK umem pages as skb frags instead of copying data to linear space. The only requirement for this for drivers is to be able to xmit skbs with skb_headlen(skb) =3D=3D 0, i.e. all data including hard headers starts from frag 0. To indicate whether a particular driver supports this, a new netdev priv flag, IFF_TX_SKB_NO_LINEAR, is added (and declared in virtio_net as it's already capable of doing it). So consider implementing this in your drivers to greatly speed-up generic XSK xmit. The first two bits refactor netdev_priv_flags a bit to harden them in terms of bitfield overflow, as IFF_TX_SKB_NO_LINEAR is the last one that fits into unsigned int. The fifth patch adds headroom and tailroom reservations for the allocated skbs on XSK generic xmit path. This ensures there won't be any unwanted skb reallocations on fast-path due to headroom and/or tailroom driver/device requirements (own headers/descriptors etc.). The other three add a new private flag, declare it in virtio_net driver and introduce generic XSK zerocopy xmit itself. The main body of work is created and done by Xuan Zhuo. His original cover letter: v3: Optimized code v2: 1. add priv_flags IFF_TX_SKB_NO_LINEAR instead of netdev_feature 2. split the patch to three: a. add priv_flags IFF_TX_SKB_NO_LINEAR b. virtio net add priv_flags IFF_TX_SKB_NO_LINEAR c. When there is support this flag, construct skb without linear space 3. use ERR_PTR() and PTR_ERR() to handle the err v1 message log: --------------- This patch is used to construct skb based on page to save memory copy overhead. This has one problem: We construct the skb by fill the data page as a frag into the skb. In this way, the linear space is empty, and the header information is also in the frag, not in the linear space, which is not allowed for some network cards. For example, Mellanox Technologies MT27710 Family [ConnectX-4 Lx] will get the following error message: mlx5_core 0000:3b:00.1 eth1: Error cqe on cqn 0x817, ci 0x8, qn 0x1dbb, opcode 0xd, syndrome 0x1, vendor syndrome 0x68 00000000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000030: 00 00 00 00 60 10 68 01 0a 00 1d bb 00 0f 9f d2 WQE DUMP: WQ size 1024 WQ cur size 0, WQE index 0xf, len: 64 00000000: 00 00 0f 0a 00 1d bb 03 00 00 00 08 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000020: 00 00 00 2b 00 08 00 00 00 00 00 05 9e e3 08 00 00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 mlx5_core 0000:3b:00.1 eth1: ERR CQE on SQ: 0x1dbb I also tried to use build_skb to construct skb, but because of the existence of skb_shinfo, it must be behind the linear space, so this method is not working. We can't put skb_shinfo on desc->addr, it will be exposed to users, this is not safe. Finally, I added a feature NETIF_F_SKB_NO_LINEAR to identify whether the network card supports the header information of the packet in the frag and not in the linear space. ---------------- Performance Testing ------------ The test environment is Aliyun ECS server. Test cmd: ``` xdpsock -i eth0 -t -S -s ``` Test result data: size 64 512 1024 1500 copy 1916747 1775988 1600203 1440054 page 1974058 1953655 1945463 1904478 percent 3.0% 10.0% 21.58% 32.3% From v3 [0]: - refactor netdev_priv_flags to make it easier to add new ones and prevent bitwidth overflow; - add headroom (both standard and zerocopy) and tailroom (standard) reservation in skb for drivers to avoid potential reallocations; - fix skb->truesize accounting; - misc comment rewords. [0] https://lore.kernel.org/netdev/cover.1611236588.git.xuanzhuo@linux.alib= aba.com Alexander Lobakin (3): netdev_priv_flags: add missing IFF_PHONY_HEADROOM self-definition netdevice: check for net_device::priv_flags bitfield overflow xsk: respect device's headroom and tailroom on generic xmit path Xuan Zhuo (3): net: add priv_flags for allow tx skb without linear virtio-net: support IFF_TX_SKB_NO_LINEAR xsk: build skb by page (aka generic zerocopy xmit) drivers/net/virtio_net.c | 3 +- include/linux/netdevice.h | 138 +++++++++++++++++++++----------------- net/xdp/xsk.c | 113 ++++++++++++++++++++++++++----- 3 files changed, 173 insertions(+), 81 deletions(-) --=20 2.30.1