Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5632842pxb; Tue, 16 Feb 2021 03:47:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRkfWkVv+UnfSU9K44WDVdwPe0RUKXMNnoVaAJgZQcjwZTl1KBvRh88jOaTHQbU+7mxoQV X-Received: by 2002:a17:906:bc84:: with SMTP id lv4mr1384619ejb.136.1613476037075; Tue, 16 Feb 2021 03:47:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613476037; cv=none; d=google.com; s=arc-20160816; b=ISqX3EtzV/JmTA0N0iStvkHUqIYKSJXDnP17KQmLDSLepggwPpokx3m0j03SLajhdF Az1JIxYsUDCdvUNC9CEflSOJwJ8Z4jSBdiRm9I/ZUOG4ARKwX+LaDhUkd/+kaiv5TnZk Y0RwZE6pzYxknu79NXa/dObM7PreKEoOh6XXM8vrIGE8Ng5aHAnDPJwtzInGmUpFmozw KdVGPYVd9Oej6EgQ4PB/4DJelaaB3Xscn7G719hUHPuUo9jFrUh98mRSryzCpX79mbMl o7MyDZAxka+lC0CzQF5BdaYGd0+nLHTbeoXPwvEoI85NiUb8smNKszoHmXGGv44mHbC3 QXqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:reply-to:cc:from:to :dkim-signature:date; bh=GZ4pOpY5bLwKn/BELyk1vidODGXYgzNWmcdf3DRVQxA=; b=V9E/yLfFOD2pNDeBkkDwz97bY4KynLiBv4r+osS1JGOvJHiLrlaRJDgoWA5IQ4I+N6 XNJKYJE2kdyZeu4v3C+hQES5xSHeXy1kMG5FI1EZjk5mZQUzB0D5pF0eR7uXge+nPxn6 Tdam/UwlwEv3WjEaegSfo/28lHQklrBLnygmlbagJCWa5LuInigciaJD/EfjenFZzLDi 2APmufFhmRzQuSgXp1p8OF8/dpX4tsWTuVtuob9f7c2A+gUY8yBWCtSM0eb27zAsk0Mi F1P+CmXqLQFNtGuMlL/w92ZSBCvzlwrmPFQI5WpPJjhibJaEL3/Dd9XbVgWcPbcBJxik K6Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=cplbIMmz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si506889edj.447.2021.02.16.03.46.54; Tue, 16 Feb 2021 03:47:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=cplbIMmz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230500AbhBPLpe (ORCPT + 99 others); Tue, 16 Feb 2021 06:45:34 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:36537 "EHLO mail-40133.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbhBPLja (ORCPT ); Tue, 16 Feb 2021 06:39:30 -0500 Date: Tue, 16 Feb 2021 11:38:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1613475527; bh=GZ4pOpY5bLwKn/BELyk1vidODGXYgzNWmcdf3DRVQxA=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=cplbIMmz+ZjB8Yk6XX7Xsca+7sdQ2S0k0sSlOETlnU8KWqTwOJS26WxgemZDO9X+2 mgFhJVNIx4PVSNqdJrsiPtPmWre5x6VrNirmm2XjpnZnQqZTF8GxCaJGGjhgCZOgaK 2bihxP5i3ML/jIa9qUrM/ZNcwLtYk7wpuLpOo1WAsA2iyaP+IFIp31RW3tPP+Yp7Hs D4eY/tPFs92pGEVjOmBToVSdBb/oy9Zix+rq21kxyy9ckruO12O6nF6RGtepr9U6JK YpVxEhvUqnKMMadeToSlCbqpuYDgRHEZuDQUg+nM/NN3nmOd5nw1Yy504BK5LDQ+pP SddQngom2GSnA== To: Magnus Karlsson , =?utf-8?Q?Bj=C3=B6rn_T=C3=B6pel?= From: Alexander Lobakin Cc: "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Paolo Abeni , Eric Dumazet , Xuan Zhuo , Dust Li , Alexander Lobakin , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Reply-To: Alexander Lobakin Subject: [PATCH v4 bpf-next 3/6] net: add priv_flags for allow tx skb without linear Message-ID: <20210216113740.62041-4-alobakin@pm.me> In-Reply-To: <20210216113740.62041-1-alobakin@pm.me> References: <20210216113740.62041-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xuan Zhuo In some cases, we hope to construct skb directly based on the existing memory without copying data. In this case, the page will be placed directly in the skb, and the linear space of skb is empty. But unfortunately, many the network card does not support this operation. For example Mellanox Technologies MT27710 Family [ConnectX-4 Lx] will get the following error message: mlx5_core 0000:3b:00.1 eth1: Error cqe on cqn 0x817, ci 0x8, qn 0x1dbb, opcode 0xd, syndrome 0x1, vendor syndrome 0x68 00000000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000030: 00 00 00 00 60 10 68 01 0a 00 1d bb 00 0f 9f d2 WQE DUMP: WQ size 1024 WQ cur size 0, WQE index 0xf, len: 64 00000000: 00 00 0f 0a 00 1d bb 03 00 00 00 08 00 00 00 00 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00000020: 00 00 00 2b 00 08 00 00 00 00 00 05 9e e3 08 00 00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 mlx5_core 0000:3b:00.1 eth1: ERR CQE on SQ: 0x1dbb So a priv_flag is added here to indicate whether the network card supports this feature. Signed-off-by: Xuan Zhuo Suggested-by: Alexander Lobakin [ alobakin: give a new flag more detailed description ] Signed-off-by: Alexander Lobakin --- include/linux/netdevice.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index fa4ab77ce81e..86e19f62f978 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1525,6 +1525,8 @@ struct net_device_ops { * @IFF_FAILOVER_SLAVE: device is lower dev of a failover master device * @IFF_L3MDEV_RX_HANDLER: only invoke the rx handler of L3 master device * @IFF_LIVE_RENAME_OK: rename is allowed while device is up and running + * @IFF_TX_SKB_NO_LINEAR: device/driver is capable of xmitting frames with + *=09skb_headlen(skb) =3D=3D 0 (data starts from frag0) */ enum netdev_priv_flags { =09IFF_802_1Q_VLAN_BIT, @@ -1558,6 +1560,7 @@ enum netdev_priv_flags { =09IFF_FAILOVER_SLAVE_BIT, =09IFF_L3MDEV_RX_HANDLER_BIT, =09IFF_LIVE_RENAME_OK_BIT, +=09IFF_TX_SKB_NO_LINEAR_BIT, =20 =09NETDEV_PRIV_FLAG_COUNT, }; @@ -1600,6 +1603,7 @@ static_assert(sizeof(netdev_priv_flags_t) * BITS_PER_= BYTE <=3D #define IFF_FAILOVER_SLAVE=09=09__IFF(FAILOVER_SLAVE) #define IFF_L3MDEV_RX_HANDLER=09=09__IFF(L3MDEV_RX_HANDLER) #define IFF_LIVE_RENAME_OK=09=09__IFF(LIVE_RENAME_OK) +#define IFF_TX_SKB_NO_LINEAR=09=09__IFF(TX_SKB_NO_LINEAR) =20 /** *=09struct net_device - The DEVICE structure. --=20 2.30.1