Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210215152438.4318-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210215152438.4318-5-nobuhiro1.iwamatsu@toshiba.co.jp>
In-Reply-To: <20210215152438.4318-5-nobuhiro1.iwamatsu@toshiba.co.jp>
From:   Naresh Kamboju <naresh.kamboju@linaro.org>
Date:   Tue, 16 Feb 2021 18:04:29 +0530
Message-ID: <CA+G9fYtDdZy=aNnB=8eQA2_h8bOtyFuizfbJzcj3OGcqJuM-Gg@mail.gmail.com>
Subject: Re: [PATCH v4 4/4] arm: dts: visconti: Add DT support for Toshiba
 Visconti5 ethernet controller
To:     Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Leon Romanovsky <leon@kernel.org>,
        Arnd Bergmann <arnd@kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, Netdev <netdev@vger.kernel.org>,
        punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        lkft-triage@lists.linaro.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Nobuhiro,


On Mon, 15 Feb 2021 at 21:00, Nobuhiro Iwamatsu
<nobuhiro1.iwamatsu@toshiba.co.jp> wrote:
>
> Add the ethernet controller node in Toshiba Visconti5 SoC-specific DT file.
> And enable this node in TMPV7708 RM main board's board-specific DT file.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
>  .../boot/dts/toshiba/tmpv7708-rm-mbrc.dts     | 18 +++++++++++++
>  arch/arm64/boot/dts/toshiba/tmpv7708.dtsi     | 25 +++++++++++++++++++
>  2 files changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> index ed0bf7f13f54..48fa8776e36f 100644
> --- a/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> +++ b/arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts
> @@ -41,3 +41,21 @@ &uart1 {
>         clocks = <&uart_clk>;
>         clock-names = "apb_pclk";
>  };
> +
> +&piether {
> +       status = "okay";
> +       phy-handle = <&phy0>;
> +       phy-mode = "rgmii-id";
> +       clocks = <&clk300mhz>, <&clk125mhz>;
> +       clock-names = "stmmaceth", "phy_ref_clk";
> +
> +       mdio0 {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "snps,dwmac-mdio";
> +               phy0: ethernet-phy@1 {
> +                       device_type = "ethernet-phy";
> +                       reg = <0x1>;

This build error was noticed on LKFT builder while building arm64 dtb
on linux next 20210216 tag.

arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dts:52.3-4 syntax error
FATAL ERROR: Unable to parse input tree

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

https://gitlab.com/Linaro/lkft/mirrors/next/linux-next/-/jobs/1033072509#L382

--
Linaro LKFT
https://lkft.linaro.org