Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: jIas1xF4TaOMw+ssUkMtzicRfSWUDAzUO3b4FTlWVdjqE2uvNGLv88+rt1kqPeX96WU+LtIsPJ
 +vsmfDa+0+/A==
IronPort-SDR: zXTNp0diplCmlIc1HMcl9+3iipNwCOEwZUWnYn4bABY29FaA3CkgDNxoeIKWy3Mx9tjPvJn2Kj
 /KU7OBGzcpRA==
Date:   Tue, 16 Feb 2021 16:39:09 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Dejin Zheng <zhengdejin5@gmail.com>
Cc:     corbet@lwn.net, jarkko.nikula@linux.intel.com,
        mika.westerberg@linux.intel.com, rric@kernel.org,
        bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, kw@linux.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] i2c: designware: Use the correct name of
 device-managed function
Message-ID: <YCvZDTLYPOvg73lb@smile.fi.intel.com>
References: <20210216141810.747678-1-zhengdejin5@gmail.com>
 <20210216141810.747678-4-zhengdejin5@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210216141810.747678-4-zhengdejin5@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Feb 16, 2021 at 10:18:09PM +0800, Dejin Zheng wrote:
> Use the new function pcim_alloc_irq_vectors() to allocate IRQ vectors,
> the pcim_alloc_irq_vectors() function, an explicit device-managed version
> of pci_alloc_irq_vectors(). If pcim_enable_device() has been called
> before, then pci_alloc_irq_vectors() is actually a device-managed
> function. It is used here as a device-managed function, So replace it
> with pcim_alloc_irq_vectors().

...

> -	r = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> +	r = pcim_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
>  	if (r < 0)
>  		return r;

It's good, but now why do we have pci_free_irq_vectors() in the same file?


-- 
With Best Regards,
Andy Shevchenko