Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] staging: greybus: minor code style fix
To:     Manikantan Ravichandran <ravman1991@gmail.com>,
        vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
        elder@kernel.org, gregkh@linuxfoundation.org
Cc:     greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
References: <20210212225035.GA16260@whach>
From:   Alex Elder <elder@ieee.org>
Message-ID: <356e8c33-36d9-95f3-1a30-322e7ef6e168@ieee.org>
Date:   Tue, 16 Feb 2021 09:31:53 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <20210212225035.GA16260@whach>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/12/21 4:50 PM, Manikantan Ravichandran wrote:
> checkpatch warning fix for string split across lines
> 
> Signed-off-by: Manikantan Ravichandran <ravman1991@gmail.com>

I think what you're doing here *looks* reasonable.  But
the GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF symbol is
a (string) numeric value that is associated with the
"s" that immediately follows it.

So I don't think your change makes sense, given the
meaning of the line you're changing.

Thanks.

					-Alex

> ---
>   drivers/staging/greybus/audio_manager_sysfs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
> index ab882cc49b41..fcd518f9540c 100644
> --- a/drivers/staging/greybus/audio_manager_sysfs.c
> +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> @@ -18,8 +18,8 @@ static ssize_t manager_sysfs_add_store(struct kobject *kobj,
>   	struct gb_audio_manager_module_descriptor desc = { {0} };
>   
>   	int num = sscanf(buf,
> -			"name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF "s "
> -			"vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
> +			"name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF
> +			"s vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
>   			desc.name, &desc.vid, &desc.pid, &desc.intf_id,
>   			&desc.ip_devices, &desc.op_devices);
>   
>