Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/4] perf report: Load PE files from debug cache only
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        "Frank Ch. Eigler" <fche@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Tommi Rantala <tommi.t.rantala@nokia.com>,
        Remi Bernon <rbernon@codeweavers.com>,
        linux-kernel@vger.kernel.org,
        Ulrich Czekalla <uczekalla@codeweavers.com>,
        Huw Davies <huw@codeweavers.com>
References: <e58e1237-94ab-e1c9-a7b9-473531906954@codeweavers.com>
 <YCqG5Z4CbMtsWZ5e@krava>
From:   Nicholas Fraser <nfraser@codeweavers.com>
Message-ID: <114e5762-b613-1bbe-22a0-4541e6a4ff0e@codeweavers.com>
Date:   Tue, 16 Feb 2021 10:55:09 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <YCqG5Z4CbMtsWZ5e@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Oops, you are correct; it is doing these checks twice. Not sure how I missed that. I'll send another patch to fix it.

Nick


On 2021-02-15 9:36 a.m., Jiri Olsa wrote:
> On Wed, Feb 10, 2021 at 02:17:38PM -0500, Nicholas Fraser wrote:
>> dso__load_bfd_symbols() attempts to load a DSO at its original path,
>> then closes it and loads the file in the debug cache. This is incorrect.
>> It should ignore the original file and work with only the debug cache.
>> The original file may have changed or may not even exist, for example if
>> the debug cache has been transferred to another machine via "perf
>> archive".
>>
>> This fix makes it only load the file in the debug cache.
>>
>> Signed-off-by: Nicholas Fraser <nfraser@codeweavers.com>
>> ---
>>  tools/perf/util/symbol.c | 8 +-------
>>  1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
>> index 64a039cbba1b..aa9ae875b995 100644
>> --- a/tools/perf/util/symbol.c
>> +++ b/tools/perf/util/symbol.c
>> @@ -1569,7 +1569,7 @@ int dso__load_bfd_symbols(struct dso *dso, const char *debugfile)
>>  	u_int i;
>>  	u64 start, len;
>>  
>> -	abfd = bfd_openr(dso->long_name, NULL);
>> +	abfd = bfd_openr(debugfile, NULL);
>>  	if (!abfd)
>>  		return -1;
>>  
>> @@ -1586,12 +1586,6 @@ int dso__load_bfd_symbols(struct dso *dso, const char *debugfile)
>>  	if (section)
>>  		dso->text_offset = section->vma - section->filepos;
>>  
>> -	bfd_close(abfd);
>> -
>> -	abfd = bfd_openr(debugfile, NULL);
>> -	if (!abfd)
>> -		return -1;
>> -
> 
> hum, should you also remove the following code?
> 
>         if (!bfd_check_format(abfd, bfd_object)) {
>                 pr_debug2("%s: cannot read %s bfd file.\n", __func__,
>                           debugfile);
>                 goto out_close;
>         }
> 
>         if (bfd_get_flavour(abfd) == bfd_target_elf_flavour)
>                 goto out_close;
> 
> it seems to be called already above
> 
> thanks,
> jirka
> 
>>  	if (!bfd_check_format(abfd, bfd_object)) {
>>  		pr_debug2("%s: cannot read %s bfd file.\n", __func__,
>>  			  debugfile);
>> -- 
>> 2.30.0
>>
>