Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5830481pxb; Tue, 16 Feb 2021 08:35:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFEatnhAhiB5/mFY5lVXhQiYW2hinkIuydGhK3wdckWk8yH4CmtjfGUjZtHDkgwFUho60j X-Received: by 2002:a05:6402:1548:: with SMTP id p8mr11843383edx.287.1613493339649; Tue, 16 Feb 2021 08:35:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613493339; cv=none; d=google.com; s=arc-20160816; b=s1i0shBVdwLWfaCIc5PKmhxl9VHtl5MTo+V7cU9fa+G3U7KvDVwvPLj/R6yHPR2uZS QKOFW+wzGoYx+vZ8IfnLkSlkLtY9EZIAihcsmRMmS62fXtVbnv5UahMWohSIR57sNcCD qtK3DXmjdzvY+qhxhgVc8h3+grQxPvOvcS1JWfy8Rj/2TaqmUHtqOCFTx5oXtB/PBJGj vCLD+mo98ZhQ23gB5SX1PZOf5d1r12NVQW72eEe6fCckno1OkLg2NXWSs9nwbnDTwfq9 zcKYcdD08ct8/zcerTNU7qo2/I0QdTTGFgN5sJXG3/WXEBkYKuHOeWaQrw+lN+70m5cF 5X8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=C9BejU0loSD2/yzLtLIxqIYxHjSoR/eyLCEUpKk2ado=; b=yzNfYmOm02Ny/J9/Vk90ydXYgvgiOd2AoHO1Qm00d8TIlzbb0WDMnB0oI7cAMnH240 +mdIngKIjk8T6ZgNehioaBkzmqNJjp3CgIptuSMq5IhFuzmpWhK7dJJjY2xniYPi+eaL DR3HJd0sQ5n3v2Xk2CniieUIqDTF8KCrITBQudWYDwqy350Hr8vpiYDjAxigvUReibXg QhbmP5Y5Qc+gOLwg7avvny1Yc1B+Q4dqQk7rYeyHrCrHzrHi0zxdDxigyy9+PSa1EEo/ JQ7aW3GgYt4JjNNP0m0CiJ7PrfP++IpXZIhYhjk2ZvGyUKAh1hI2yZxOsRbVVLqJBAJj DUGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id uz29si15202034ejb.527.2021.02.16.08.35.15; Tue, 16 Feb 2021 08:35:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbhBPQdI convert rfc822-to-8bit (ORCPT + 99 others); Tue, 16 Feb 2021 11:33:08 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:42323 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbhBPQdH (ORCPT ); Tue, 16 Feb 2021 11:33:07 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-47-h1rLAFRZMNSVDB9RE5cVhw-1; Tue, 16 Feb 2021 16:31:27 +0000 X-MC-Unique: h1rLAFRZMNSVDB9RE5cVhw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 16 Feb 2021 16:31:26 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 16 Feb 2021 16:31:26 +0000 From: David Laight To: 'Jarkko Sakkinen' , Jason Gunthorpe CC: Lino Sanfilippo , "peterhuewe@gmx.de" , "stefanb@linux.vnet.ibm.com" , "James.Bottomley@hansenpartnership.com" , "linux-integrity@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Lino Sanfilippo , "stable@vger.kernel.org" Subject: RE: [PATCH v4] tpm: fix reference counting for struct tpm_chip Thread-Topic: [PATCH v4] tpm: fix reference counting for struct tpm_chip Thread-Index: AQHXBH2yJiAHL3ooWkeUp1zIrnNHeapa+MWQ Date: Tue, 16 Feb 2021 16:31:26 +0000 Message-ID: <74bbc76260594a8a8f7993ab66cca104@AcuMS.aculab.com> References: <1613435460-4377-1-git-send-email-LinoSanfilippo@gmx.de> <1613435460-4377-2-git-send-email-LinoSanfilippo@gmx.de> <20210216125342.GU4718@ziepe.ca> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... > > > + get_device(&chip->dev); > > > + chip->devs.release = tpm_devs_release; > > > + chip->devs.devt = > > > + MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES); > > Isn't this less than 100 chars? Still best kept under 80 if 'reasonable'? Really it is just split in the wrong place: chip->devs.devt = MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES); David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)