Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5902033pxb; Tue, 16 Feb 2021 10:18:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJwocVikDq9cVkFRMX6GtaIKaCt9ui4bNh7TztN1jPDptOK++FpoRj1ZJRlRCmAP/1jXcpaq X-Received: by 2002:a50:da4f:: with SMTP id a15mr6827082edk.301.1613499484936; Tue, 16 Feb 2021 10:18:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613499484; cv=none; d=google.com; s=arc-20160816; b=pS2SwhsbEBaR64Zon2G967zfe7U0Pg1Q5ZTk2W3+QRAAq65vZQGnA+evB0HKOoc2Hc WP8nBuhOYt5F7Zt74SKNznE52kRme4WHTZcXMMMDneNuCjBQdra0OX3vFwbb6gtGcoGD fkwuTr0f3Gp+ezz5pejzgZ+IqwAgOpHPGJiHgyYQtB1hSsSfhWzLYjRNLjpPDWIbkbOZ oiEIyyrPjgz6ju/WjfA++c+JweGt+dDPorV5aVsPYnxHXVrqjLTGqIQ5JVLPFrIGyIHF JUfka2pInFF+/X4wI7SYQKtbWNKfQjvKGwgm6kFRRlpSK2tjIeGdxcVRwzrE/LwYNIDv l7UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=ZU6Ywodns51bdAxmwFarGloTJ5/ETv0AH+rT9S1HwyE=; b=TTw9NdFj9zmmkajaRdyGPttnMFHaOU6MRy5tf8jx/ox+JjqDXJkezKdjO8MU1VrF6d cosmtl0daYZswPK5rigKtf6lK9ZPM9BA+jBG+Llqbvl3IcVtfwRMOBtgvyfvJDGRaQJA TqXyLAXMfWI7HWQ2/ajixFajTZ8mcPBkXtxUlZd1SiD4BMHZhsJiE2PvfuZA2KyUTlYS CGm7n/0w+dfl3980s0H0n9dnoZ+faafH/VIy14piwsCDcavH4PhfAH7ob2bf/5QvO+8S bx1ZPsaaFtCRpzV2YYCb9f5JWeDGf8VvZLIHzq7/w8+7mRQdtz0GzuCw/z8oEfV7XU/M m6Xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q14si15316708ejy.320.2021.02.16.10.17.41; Tue, 16 Feb 2021 10:18:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230428AbhBPSQn (ORCPT + 99 others); Tue, 16 Feb 2021 13:16:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:32818 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229889AbhBPSQ2 (ORCPT ); Tue, 16 Feb 2021 13:16:28 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 18EB2AB4C; Tue, 16 Feb 2021 18:15:46 +0000 (UTC) Subject: Re: [RFC/RFT PATCH] scsi: pm8001: Expose HW queues for pm80xx hw To: Viswas.G@microchip.com, john.garry@huawei.com, jejb@linux.ibm.com, martin.petersen@oracle.com, akshatzen@google.com, Ruksar.devadi@microchip.com, radha@google.com, bjashnani@google.com, vishakhavc@google.com, jinpu.wang@cloud.ionos.com, Ashokkumar.N@microchip.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kashyap.desai@broadcom.com, ming.lei@redhat.com References: <1609845423-110410-1-git-send-email-john.garry@huawei.com> <0a20dc79-a462-f3fb-14af-db151b688e5a@huawei.com> <1b491d44-996c-2131-2eb6-5348460f9b5b@huawei.com> From: Hannes Reinecke Message-ID: <23f6201d-130a-5bf3-c828-c06f0e0acfbe@suse.de> Date: Tue, 16 Feb 2021 19:15:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/15/21 6:31 PM, Viswas.G@microchip.com wrote: > Hi John, > > We could test this patch and it works fine. Regarding the usage of request->tag, We have some challenges there. > Pm80xx driver need tag for internal command as well. Tag is controller wide and we need to assign unique tag > for internal command as well. If we use request->tag, how can we get tag for internal commands ? If driver > allocate that, how can we make sure it will not conflict with the request->tag ? > I have posted a patchset for internal tags some time ago; at the time it was blocked by the missing shared tagset functionality. But seeing that we're having it now I guess I'll need to repost; that addresses precisely the issue you've described. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer