Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAM_iQpVEZiOca0po6N5Hcp67LV98k_PhbEXogCJFjpOR0AbGwg@mail.gmail.com>
 <20210216162200.1834139-1-vladbu@nvidia.com>
In-Reply-To: <20210216162200.1834139-1-vladbu@nvidia.com>
From:   Cong Wang <xiyou.wangcong@gmail.com>
Date:   Tue, 16 Feb 2021 11:05:03 -0800
Message-ID: <CAM_iQpWqFgi8BqSN3QnJUNVO5Y+B+LpcnKymPgqPo4LUM=F8VQ@mail.gmail.com>
Subject: Re: [PATCH net] net: sched: fix police ext initialization
To:     Vlad Buslov <vladbu@nvidia.com>
Cc:     syzbot <syzbot+151e3e714d34ae4ce7e8@syzkaller.appspotmail.com>,
        David Miller <davem@davemloft.net>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Jakub Kicinski <kuba@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 16, 2021 at 8:22 AM Vlad Buslov <vladbu@nvidia.com> wrote:
>
> When police action is created by cls API tcf_exts_validate() first
> conditional that calls tcf_action_init_1() directly, the action idr is not
> updated according to latest changes in action API that require caller to
> commit newly created action to idr with tcf_idr_insert_many(). This results
> such action not being accessible through act API and causes crash reported
> by syzbot:

Good catch!

This certainly makes sense to me, and I feed it to syzbot too, it is happy
with this patch, so:

Reported-and-tested-by: syzbot+151e3e714d34ae4ce7e8@syzkaller.appspotmail.com
Reviewed-by: Cong Wang <xiyou.wangcong@gmail.com>

Thanks.