Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip
To:     Jarkko Sakkinen <jarkko@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>
Cc:     peterhuewe@gmx.de, stefanb@linux.vnet.ibm.com,
        James.Bottomley@hansenpartnership.com,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        stable@vger.kernel.org
References: <1613435460-4377-1-git-send-email-LinoSanfilippo@gmx.de>
 <1613435460-4377-2-git-send-email-LinoSanfilippo@gmx.de>
 <20210216125342.GU4718@ziepe.ca> <YCvtF4qfG35tHM5e@kernel.org>
 <YCvuS9cIT7umOjhy@kernel.org> <YCvulinbuHWunTqD@kernel.org>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <527e8905-d727-3a45-f542-5827fa0bca47@gmx.de>
Date:   Tue, 16 Feb 2021 20:08:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YCvulinbuHWunTqD@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On 16.02.21 at 17:11, Jarkko Sakkinen wrote:
> On Tue, Feb 16, 2021 at 06:09:50PM +0200, Jarkko Sakkinen wrote:
>> On Tue, Feb 16, 2021 at 06:04:42PM +0200, Jarkko Sakkinen wrote:
>>> On Tue, Feb 16, 2021 at 08:53:42AM -0400, Jason Gunthorpe wrote:
>>>> On Tue, Feb 16, 2021 at 01:31:00AM +0100, Lino Sanfilippo wrote:
>>>>>
>>>>> +static int tpm_add_tpm2_char_device(struct tpm_chip *chip)
>>>
>>> BTW, this naming is crap.
>>>
>>> - 2x tpm
>>> - char is useless
>>>
>>> -> tpm2_add_device
>>
>> Actually, tpm2s_add_device() add put it to tpm2-space.c.
>
> No, tpms_add_device() :-)
>
> (sorry)
>
> /Jarkko
>

I strongly assume you mean tmp2_add_device() :) I will move and rename the=
 function
accordingly.

Thanks,
Lino