Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip
To:     Jarkko Sakkinen <jarkko@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>
Cc:     peterhuewe@gmx.de, stefanb@linux.vnet.ibm.com,
        James.Bottomley@hansenpartnership.com,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        stable@vger.kernel.org, David Laight <David.Laight@ACULAB.COM>
References: <1613435460-4377-1-git-send-email-LinoSanfilippo@gmx.de>
 <1613435460-4377-2-git-send-email-LinoSanfilippo@gmx.de>
 <20210216125342.GU4718@ziepe.ca> <YCvtF4qfG35tHM5e@kernel.org>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <a9327758-dbd7-9272-b580-c9807bad2e24@gmx.de>
Date:   Tue, 16 Feb 2021 20:15:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YCvtF4qfG35tHM5e@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

On 16.02.21 at 17:04, Jarkko Sakkinen wrote:

>>> +	/*
>>> +	 * get extra reference on main device to hold on behalf of devs.
>>> +	 * This holds the chip structure while cdevs is in use. The
>>> +	 * corresponding put is in the tpm_devs_release.
>>> +	 */
>>> +	get_device(&chip->dev);
>>> +	chip->devs.release =3D tpm_devs_release;
>>> +	chip->devs.devt =3D
>>> +		MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES);
>
> Isn't this less than 100 chars?
>

I just chose the same formatting that the original code used. Personally I=
 prefer what
David suggested, so if there is no objection against it I will format it t=
his way.

Regards,
Lino