Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5976694pxb; Tue, 16 Feb 2021 12:25:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJzYZLBLdy5sgHrt6bO3n9lijx0wsY1+oYFn2WFt1gL6EQhyQr//Ice3J6nGcTF6M6YNWjfK X-Received: by 2002:a17:907:2957:: with SMTP id et23mr6605728ejc.543.1613507107299; Tue, 16 Feb 2021 12:25:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613507107; cv=none; d=google.com; s=arc-20160816; b=nSN2F90lsezYsu16yLuSxj0ROW3PXXKW94i2MZ0XsQEWwe4A9FrFqeZ3OeKELxyxI/ ZM/xeO2dBhLn4vXJA0QDtMo2/FhVUiA+ENYDAFgtINwzhn+EEbWXe2LZ9cKEmYYLUTcg nrbgRWpGDAdLVKbfGJrXsC0vjL3Z0n/iHVhjVZvyODGVtFAahkXnaPQD4anYjvFgnJC1 A/l3TL8shdqRYapp9mvUgOO+bclrgRhRuHWxQcRt2Hh9CVhc3PMvBWEC/vvVLg/0xnvC gvwjvzSMB/nPnqne06+g/Doe+lth/pTYf8GfnKY0IHTUZFNUKvbZ55/n8rQn2QA27fji tHfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=E6mT1eLy2BbvLR20EYpVVGUzTe4X8rj8sSx2cY7U1BQ=; b=NewzD7lzNnGQIPM/c11uyxnfpqofd/ShmyR75SMMIULecZXxNO5nJ8JIScPIndLRm6 q50XPnF+bo3sQ7+qiTHQkL1pRT0R1rR9DFbEVfOGXqwRbY21ojiYEpuxIokK/VL2Xz5M oN4UEaMjZHpPZOerQ1hckbZQmUPPHB59zzfZB1GqqffCFlVrcC+d8t78JtscqWbK+n62 DZOsElNJ5Je2b+hGvmy/YXQdOt4Mn9RPVC81jpVK68rzOHzaKOfd8fEuIU4SVIft3IkM 8OtW6GymyO9QY2NkqSgidq20bfLWjltrV6fbHI45JgOGbAvHsGL8ijGWM1mS9mEWVOYw fSJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@libero.it header.s=s2014 header.b=R0p+YkvS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=libero.it Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p31si19943264edb.114.2021.02.16.12.24.44; Tue, 16 Feb 2021 12:25:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@libero.it header.s=s2014 header.b=R0p+YkvS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=libero.it Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbhBPUXu (ORCPT + 99 others); Tue, 16 Feb 2021 15:23:50 -0500 Received: from smtp-17.italiaonline.it ([213.209.10.17]:51909 "EHLO libero.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230063AbhBPUXo (ORCPT ); Tue, 16 Feb 2021 15:23:44 -0500 Received: from passgat-Modern-14-A10M.homenet.telecomitalia.it ([87.20.116.197]) by smtp-17.iol.local with ESMTPA id C6s3lYbQ2lChfC6s8ldxSs; Tue, 16 Feb 2021 21:23:01 +0100 x-libjamoibt: 1601 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=libero.it; s=s2014; t=1613506981; bh=E6mT1eLy2BbvLR20EYpVVGUzTe4X8rj8sSx2cY7U1BQ=; h=From; b=R0p+YkvSKiJb69sWwvh/538Jj5YMnNJeEzMGYhyTKSk9qkGza9NS83I0aVxcSDvc4 vgpyOqM54OkbC685W6L/z7X3no5dx9LTzvPHutuCnbR9aGAaVwwEL5FrBYBbAR1AZx 9HdeErD3VcyOP79FzADRW17gW7FxzA0hfPXdsWBkfSM9E5wdhbXaLKXo+zL+hHwpu2 TL8ossOCOVPii3CeRCJHAxkapQZEPmFupYDhE+dyhCcPsbOuX6f/IJuRe3KOOtCpjE Y8/sYDG5nIw/wwyFLsbI7sm/0BG5MhL8mPfUpY6rObP2IeFmm/59aAejggecV527wg LK/MoIleWQGvQ== X-CNFS-Analysis: v=2.4 cv=S6McfKgP c=1 sm=1 tr=0 ts=602c29a5 cx=a_exe a=AVqmXbCQpuNSdJmApS5GbQ==:117 a=AVqmXbCQpuNSdJmApS5GbQ==:17 a=toUk0IfjeMrTqMqL6ioA:9 From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Daniel Vetter , David Airlie , Jyri Sarha , Tomi Valkeinen , dri-devel@lists.freedesktop.org Subject: [RESEND PATCH] drm/tilcdc: fix raster control register setting Date: Tue, 16 Feb 2021 21:22:25 +0100 Message-Id: <20210216202225.12861-1-dariobin@libero.it> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4xfN2H0V+jFPpOEwOIINj7kCHNlbmpcTscidCmgWRHfxmf1Mt6v6HmETHBNVuGkDrV9m31GyCnUS2ee3To+J/nJjhwX+yOFKzbNE/Wp69NtBgl0/u43DD/ STXeLVds16KSqdvw34IRGbcRlVfeRirszrDSKDAcNIiVPuoZcUUQy4HKthJq8X4MHzogCFAmEZsa2nyjOYBKow3InfWVyktXeebVc8H4/2w7ak+THVw28Qjv rIBnYAGuSM95lHZBI9wA78ymzpdCW8mZPWmQVkbXdZDfz9Vtm6k7Wf9mgtIMQJRA9atrhDzWJLmfPpd/mNpgmIBWrmRxrOChXS8uzEIRqwF3ab0fzqyxLzhp 9wxQXF7YCz5xFlwbnS20EqLh+EfBrB3m1m/K4VJaOXP6c3VAd/UmPdRvvrQLihFSfxFc6xWqG8KtucW77CN0qelHTij28A== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c index 30213708fc99..238068e28729 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c @@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) return; } } - reg |= info->fdd < 12; + reg |= info->fdd << 12; tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg); if (info->invert_pxl_clk) -- 2.17.1