Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210216123958.3180014-1-geert+renesas@glider.be> <CAGETcx_YeiNAMkSxtbTSZcsQugxK4=CwhR6UfbSLLHzQ2EfguA@mail.gmail.com>
In-Reply-To: <CAGETcx_YeiNAMkSxtbTSZcsQugxK4=CwhR6UfbSLLHzQ2EfguA@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 16 Feb 2021 21:33:39 +0100
Message-ID: <CAMuHMdXeR5UkEOjNNHscQX+vCxMFEW-r6FXn14s+mtKDXsbm_Q@mail.gmail.com>
Subject: Re: [PATCH v2] soc: renesas: rmobile-sysc: Mark fwnode when PM domain
 is added
To:     Saravana Kannan <saravanak@google.com>
Cc:     Magnus Damm <magnus.damm@gmail.com>,
        Sebastian Reichel <sre@kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Saravana,

On Tue, Feb 16, 2021 at 7:26 PM Saravana Kannan <saravanak@google.com> wrote:
> On Tue, Feb 16, 2021 at 4:40 AM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > Currently, there are two drivers binding to the R-Mobile System
> > Controller (SYSC):
> >   - The rmobile-sysc driver registers PM domains from a core_initcall(),
> >     and does not use a platform driver,
> >   - The optional rmobile-reset driver registers a reset handler, and
> >     does use a platform driver.
> >
> > As fw_devlink only considers devices, commit bab2d712eeaf9d60 ("PM:
> > domains: Mark fwnodes when their powerdomain is added/removed") works
> > only for PM Domain drivers where the DT node is a real device node, and
> > not for PM Domain drivers using a hierarchical representation inside a
> > subnode.  Hence if fw_devlink is enabled, probing of on-chip devices
> > that are part of the SYSC PM domain is deferred until the optional
> > rmobile-reset driver has been bound.   If the rmobile-reset driver is
> > not available, this will never happen, and thus lead to complete system
> > boot failures.
> >
> > Fix this by explicitly marking the fwnode initialized.
> >
> > Suggested-by: Saravana Kannan <saravanak@google.com>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > This is v2 of "soc: renesas: rmobile-sysc: Set OF_POPULATED and absorb
> > reset handling".
> > To be queued in renesas-devel as a fix for v5.12 if v5.12-rc1 will have
> > fw_devlink enabled.

> Acked-by: Saravana Kannan <saravanak@google.com>

Thanks!

> Keep in mind that this might have to land in driver-core-next since
> that API is currently only in driver-core-next.

That will be resolved once driver-core-next has been merged in v5.12-rc1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds