Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp5984270pxb; Tue, 16 Feb 2021 12:39:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJymV/G98fcAgNNlBqezZv/u4z1fwG3pxBX5ZTKoAxapzoAXRbUrdmmYG4997CmFQ2OrOGZI X-Received: by 2002:a17:907:da3:: with SMTP id go35mr21457042ejc.26.1613507993764; Tue, 16 Feb 2021 12:39:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613507993; cv=none; d=google.com; s=arc-20160816; b=mXIQilQpVWL9JnR9RCV3GU8sdBRfpchk9LlpoJePOOllXEoCgYL7MbGsqejaKYR+Uo DEyI4lHtraNF5TPEyRRmePPO2HD6jl/ulg6nOkV+l4/xvfrdqfm/6dDzLpa1J8aAyB6P v5MDarE0LSqVZh2ngo97ZYnzOr15NcBSr02cyUPxy9Gs8SuUJOjsRkNZ+LneufiYPHFx hQxW6zN4BdMMjuA7xGuRGr5HpVuV19f2+wudufCVnAvPVC5ixr2y+rvM3MmA25HZ0Iuh w+QbXIy+rWq8IxXgLzCu/XFgMj5M9zbsBJ2RGUlyPVSU8NxecgFJn+BfJEpZtEx8ITY4 THhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:references:cc :to:from:subject:dkim-signature; bh=tKQ2pWJwqZVLEuwEbyo5pWr2TNaoG+vSytCCe2na47s=; b=SGd3tsJ44Z1xKX8iZuXbJ1evoBU6LZKSDJepPnTV2Nhx/Dqvr9UBmkOWHJpWe+K3Yx aKqBHjWf21Uubc9X9pfgLsN0Te5/3Sj9oT4+n2XlEl0i4cw5QWWDsx3Jr3sqiDQDr81g 6x8rEBYazIxIpr9h2IxWi8jUxHnlqlSn2xdU+WGSvLg2VYV9JA355UsxkLnCqdqhknxn Ono/8IrebAy2QwT7daKOcaSvqY3fxYuGeqC2wtTnMpiPN4pJZ6LFYdc6QC9yOytQ8M2N BUNKWty6DPhmfON2IAdjlZs5dHA4OOk1MBMOKd53DN+PaBvdWcYVHUHczyx+goCx7dpN iiKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@codeweavers.com header.s=6377696661 header.b=wcIbEerz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codeweavers.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p14si7860584edm.81.2021.02.16.12.39.29; Tue, 16 Feb 2021 12:39:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@codeweavers.com header.s=6377696661 header.b=wcIbEerz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codeweavers.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbhBPUiV (ORCPT + 99 others); Tue, 16 Feb 2021 15:38:21 -0500 Received: from mail.codeweavers.com ([50.203.203.244]:46264 "EHLO mail.codeweavers.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbhBPUiU (ORCPT ); Tue, 16 Feb 2021 15:38:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=6377696661; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tKQ2pWJwqZVLEuwEbyo5pWr2TNaoG+vSytCCe2na47s=; b=wcIbEerzaB3RtTVKYIsuaD5M8Z oZ5Fu64A7QEMBzSiigqCPH5WZ8HDBXL/zJ/K9lEZhg1IV7uDURe5Gac68Mfl3ZRdC8IKifp7xEF0C Db98YClhb8hJlZB4H+ahC8Prn+8ZvMFaVqbpEtLauxu7xOYx5HJWkdm5ZHoI9ppmd/+w=; Received: from [10.69.141.136] by mail.codeweavers.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lC76B-0001rg-Qy; Tue, 16 Feb 2021 14:37:34 -0600 Subject: [PATCH 1/2] perf report: Remove redundant libbfd checks From: Nicholas Fraser To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , "Frank Ch. Eigler" , Song Liu , Adrian Hunter , Kim Phillips , Tommi Rantala , Remi Bernon , linux-kernel@vger.kernel.org Cc: Ulrich Czekalla , Huw Davies References: Message-ID: <94758ca1-0031-d7c6-6c6a-900fd77ef695@codeweavers.com> Date: Tue, 16 Feb 2021 15:37:20 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -40.5 X-Spam-Report: Spam detection software, running on the system "mail.codeweavers.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This removes the redundant checks bfd_check_format() and bfd_target_elf_flavour. They were previously checking different files. --- tools/perf/util/symbol.c | 9 --------- 1 file changed, 9 deletions(- [...] Content analysis details: (-40.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 USER_IN_WELCOMELIST user is listed in 'welcomelist_from' -20 USER_IN_WHITELIST DEPRECATED: See USER_IN_WELCOMELIST -20 ALL_TRUSTED Passed through trusted hosts only via SMTP -0.5 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 AWL AWL: Adjusted score from AWL reputation of From: address Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This removes the redundant checks bfd_check_format() and bfd_target_elf_flavour. They were previously checking different files. --- tools/perf/util/symbol.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 492c873713cc..08f6f57c84fd 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -1586,15 +1586,6 @@ int dso__load_bfd_symbols(struct dso *dso, const char *debugfile) if (section) dso->text_offset = section->vma - section->filepos; - if (!bfd_check_format(abfd, bfd_object)) { - pr_debug2("%s: cannot read %s bfd file.\n", __func__, - debugfile); - goto out_close; - } - - if (bfd_get_flavour(abfd) == bfd_target_elf_flavour) - goto out_close; - symbols_size = bfd_get_symtab_upper_bound(abfd); if (symbols_size == 0) { bfd_close(abfd); -- 2.30.1