Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ionic: Remove unused function pointer typedef
 ionic_reset_cb
To:     Chen Lin <chen45464546@163.com>, davem@davemloft.net,
        kuba@kernel.org
Cc:     drivers@pensando.io, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Chen Lin <chen.lin5@zte.com.cn>
References: <1613448330-4783-1-git-send-email-chen45464546@163.com>
From:   Shannon Nelson <snelson@pensando.io>
Message-ID: <93451a68-293a-2f21-f837-317778c18c89@pensando.io>
Date:   Tue, 16 Feb 2021 13:26:41 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <1613448330-4783-1-git-send-email-chen45464546@163.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 2/15/21 8:05 PM, Chen Lin wrote:
> From: Chen Lin <chen.lin5@zte.com.cn>
>
> Remove the 'ionic_reset_cb' typedef as it is not used.
>
> Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
> ---
>   drivers/net/ethernet/pensando/ionic/ionic_lif.h |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.h b/drivers/net/ethernet/pensando/ionic/ionic_lif.h
> index 9bed427..563dba3 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.h
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.h
> @@ -249,8 +249,6 @@ static inline u32 ionic_coal_usec_to_hw(struct ionic *ionic, u32 usecs)
>   	return (usecs * mult) / div;
>   }
>   
> -typedef void (*ionic_reset_cb)(struct ionic_lif *lif, void *arg);
> -
>   void ionic_link_status_check_request(struct ionic_lif *lif, bool can_sleep);
>   void ionic_get_stats64(struct net_device *netdev,
>   		       struct rtnl_link_stats64 *ns);

Yep - thanks.

Acked-by: Shannon Nelson <snelson@pensando.io>