Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: NTohzzE1iJ5dUa3ih+H6KN48LS/39yJACw7ZEXE35cLl0a31yes/NOrGczBjfk7l9wiH4bw/rX
 rOEWOwLbK5ZdpBg+QbImIse4BTy880BC6oeZ4lEowyENXwNMTEgXnBb+rpqzoaCspckWce5htQ
 x/FgC+idrDs75NVt2t3tAPJDl/mjGi6Z1ccZ+pVXUhHrHIiMhkMUQw8B3q2kaDWpEJ5COjTZRi
 nT8NlKNJosYBWk2HmxtL+2GCnTIoq0K3dYV5WsY548Z7fyHf1HO1QRfM+PaE9TmPp74nVngbBH
 RPk=
Date:   Tue, 16 Feb 2021 23:08:04 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Pavel Machek <pavel@denx.de>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 5.10 098/104] switchdev: mrp: Remove
 SWITCHDEV_ATTR_ID_MRP_PORT_STAT
Message-ID: <20210216220804.iadtjpg7r3masi5m@soft-dev3.localdomain>
References: <20210215152719.459796636@linuxfoundation.org>
 <20210215152722.633343806@linuxfoundation.org>
 <20210216213508.GA32671@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20210216213508.GA32671@amd>
Precedence: bulk

The 02/16/2021 22:35, Pavel Machek wrote:

Hi,

> Hi!
> 
> > From: Horatiu Vultur <horatiu.vultur@microchip.com>
> > 
> > commit 059d2a1004981dce19f0127dabc1b4ec927d202a upstream.
> > 
> > Now that MRP started to use also SWITCHDEV_ATTR_ID_PORT_STP_STATE to
> > notify HW, then SWITCHDEV_ATTR_ID_MRP_PORT_STAT is not used anywhere
> > else, therefore we can remove it.
> 
> Are you sure this is suitable for 5.10 backport? Unlike mainline,
> net/bridge use is not removed, so this will cause compile problem...?
> 
> pavel@amd:~/cip/krc$ grep -ri SWITCHDEV_ATTR_ID_MRP_PORT_STATE .
> ./include/net/switchdev.h:    SWITCHDEV_ATTR_ID_MRP_PORT_STATE,
> ./net/bridge/br_mrp_switchdev.c:		.id = SWITCHDEV_ATTR_ID_MRP_PORT_STATE,
> pavel@amd:~/cip/krc$ e ./net/bridge/br_mrp_switchdev.c

The usage of SWITCHDEV_ATTR_ID_MRP_PORT_STATE in
net/bridge/br_mrp_switchdev.c is removed in this patch:
https://www.spinics.net/lists/stable/msg443626.html

> 
> Best regards,
> 								Pavel
> 
> > --- a/include/net/switchdev.h
> > +++ b/include/net/switchdev.h
> > @@ -41,7 +41,6 @@ enum switchdev_attr_id {
> >  	SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED,
> >  	SWITCHDEV_ATTR_ID_BRIDGE_MROUTER,
> >  #if IS_ENABLED(CONFIG_BRIDGE_MRP)
> > -	SWITCHDEV_ATTR_ID_MRP_PORT_STATE,
> >  	SWITCHDEV_ATTR_ID_MRP_PORT_ROLE,
> >  #endif
> >  };
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


-- 
/Horatiu