Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210126021331.1059933-1-ruansy.fnst@cn.fujitsu.com> <b685493f-98f5-9717-f88a-308e96440dcd@oracle.com>
In-Reply-To: <b685493f-98f5-9717-f88a-308e96440dcd@oracle.com>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Tue, 16 Feb 2021 14:38:55 -0800
Message-ID: <CAPcyv4gdeg+RfATJx8Ls4E=FE913JuxftdO1vhsoWJh+_bpe1w@mail.gmail.com>
Subject: Re: [PATCH] dax: fix default return code of range_parse()
To:     Joao Martins <joao.m.martins@oracle.com>
Cc:     Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-nvdimm <linux-nvdimm@lists.01.org>,
        Vishal L Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Zhang Qilong <zhangqilong3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 10, 2021 at 10:19 AM Joao Martins <joao.m.martins@oracle.com> wrote:
>
> On 1/26/21 2:13 AM, Shiyang Ruan wrote:
> > The return value of range_parse() indicates the size when it is
> > positive.  The error code should be negative.
> >
> > Signed-off-by: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
>
> Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
>
> Although, FWIW, there was another patch exactly like this a couple
> months ago, albeit it didn't get pulled for some reason:
>
> https://lore.kernel.org/linux-nvdimm/20201026110425.136629-1-zhangqilong3@huawei.com/

Apologies for missing these... applied now.