Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp6147872pxb; Tue, 16 Feb 2021 18:15:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJwi1/ZEMbBH8cygJQ+XwXyyUCNRjHkf49Nho/AvBF2Z/Y0t2lKcNTUMfdYk223MroRENunb X-Received: by 2002:a17:906:ad9:: with SMTP id z25mr23784498ejf.513.1613528111277; Tue, 16 Feb 2021 18:15:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613528111; cv=none; d=google.com; s=arc-20160816; b=I+0j4XZP2dK5aLIH+fQy8Ym5VdzYrO69ORwQIVM2PoatX/ep9SvAM7qCcfWUGVMtrc a9q+EjozqY/ypbd8Ut6MynuuHYxmkQqSydIqXMYVNajomBrjGEE2QBuZgDz2Zn2kSkJk TCv5JuGIGwjaPTd3DFacu3K4LECu8AUGWOGYhsYzmHtCNvL7egQjJ7PE/MKNwHHJsc9v QvFOKMwPRziV9T+V5URy5DNnRRAqi8wH0E2Zas5zz04W0VxhJUpc5oI9HSKtFwiamb/Q jMO3oWEUBdENY8nLsmKT+EXqlyFfu3lUBCqRbqErNss0sG46B/yK6OxUaC0zy25zvNv4 AB5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=aUUOJlgDQumqSSsn6b2nMo56O2uNsyRlZI5+0ZRl54U=; b=gwVnqR345fp1/GB0y0scfJ2bQdgiUeVhToct7uavsMJnlvmusZ6Zj75y2B6btvYq4c TZE9JcnJ8nhvD/yQA2p9X2I81Vo2xp5tIm3ZmOOcArOhk6a8d6qtbOfbtqjMBxE72lS+ hvXz33FMBLNbnkhHp8sQMaIzAT+MQAXXi6docg3Pw3cOTeauDSBpt7XPjxczmtNik8AJ us4OdkhiPG/Z2+YAES0EUzB6bPVCWnhxFp9lDgestJQQ9LrQYlo16jK42itX/TX/mf7J +hjusH7yfpjQNWSOZbVCUJu0Gg8RRRzrIgnyQts8uFhKhr0GHjViH8+fOC8pcln/BYi+ Ss9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=KqWjsFog; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r12si267306edd.539.2021.02.16.18.14.46; Tue, 16 Feb 2021 18:15:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=KqWjsFog; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbhBQBlp (ORCPT + 99 others); Tue, 16 Feb 2021 20:41:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229787AbhBQBlo (ORCPT ); Tue, 16 Feb 2021 20:41:44 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47C72C061574 for ; Tue, 16 Feb 2021 17:41:04 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id w1so10533883ejk.6 for ; Tue, 16 Feb 2021 17:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aUUOJlgDQumqSSsn6b2nMo56O2uNsyRlZI5+0ZRl54U=; b=KqWjsFoguTrjWzkyFDr4S7tTXgUIqm3Y4PfT/ofs5LnJNHjNgmSKwxSugOcsMWm6+H BoTlzMwTcNvHP6B0Bnl3Xw5Fe2tGprhZ2GPvM0Rn5udBuHOtQcFGiGfqkHM0oyecYmCz cKX/9lGvNYEBWtBhHKAZXOmol7P8xRKTge5POr7MV4CoGSMG6hqh5BbhJL2+h+QGvnqW XRTkRKha1iNLzP1IjVsvvhGwzrFR4R8anK/4zjo6cMe7tEDTn+DyDAOKf/rR5EYO6O9x Py/EDa7UkNGrJnz+qr3Y2R1KVSjVymb7XbkoDsAlcn8nQDCNjTw6dBJlhYLqjZLQow/f jUtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aUUOJlgDQumqSSsn6b2nMo56O2uNsyRlZI5+0ZRl54U=; b=SZuQ5mc/wDCme1KP0Vqk/aq3BU52vB31+xQsWA+ZvLg8OocR0z27JmbBQqaTcNaa9q y6WTGDMGT0NiNgm+MnxHHGIE+3wKz/9bMfp2lW1MF4g5klQ4uBldFDDkqT/OhN5WNzdf KhOicRKeuM4f550ShSRD/FYdnfaVGobzrUm0wuNXYXlai/iABheP2hn9p+oB535xWw8X Goh0MPeC3ZhMTNv/iwu0nf5yy5CpNAu57ias3xBM0PpoKttr5/D0xg1bPpNMdKp+2ZxH KGk8bE1mFeyrTHFH9AtisUqn4X+u025tmyyFqK2dHJRrXI54wgyGkLNU1W1qafpQvYia 6xCw== X-Gm-Message-State: AOAM530XIaV867ayxIGGGlBy10fh/Fghhnzg2QeZfu7W3KK1R0Igkxvk tPmnuVQq+Q9TO8pPIHkCA38/2zZxwnd3NbZo1sgDHA== X-Received: by 2002:a17:906:1352:: with SMTP id x18mr17937904ejb.418.1613526062947; Tue, 16 Feb 2021 17:41:02 -0800 (PST) MIME-Version: 1.0 References: <20210212171043.2136580-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210212171043.2136580-1-u.kleine-koenig@pengutronix.de> From: Dan Williams Date: Tue, 16 Feb 2021 17:40:53 -0800 Message-ID: Subject: Re: [PATCH 1/2] libnvdimm: simplify nvdimm_remove() To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Greg Kroah-Hartman , kernel@pengutronix.de, linux-nvdimm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2021 at 9:11 AM Uwe Kleine-K=C3=B6nig wrote: > > nvdimm_remove is only ever called after nvdimm_probe() returned > successfully. In this case driver data is always set to a non-NULL value > so the check for driver data being NULL can go away as it's always false. Looks good, thanks.