Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp6182029pxb; Tue, 16 Feb 2021 19:43:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwR0qjKoYOjHsT+k0r/HXVSbCoCCO0Uah27fEu31+iotVQIEC1UdmPZVQRw4/8hQFPg7ygR X-Received: by 2002:a17:907:e8c:: with SMTP id ho12mr9080965ejc.435.1613533402858; Tue, 16 Feb 2021 19:43:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613533402; cv=none; d=google.com; s=arc-20160816; b=kX4sPQ1K9fZaK3z/tpd0xJPO83+qYSW3DQ0PQoVtrPIKPXQnmcWkWOczvk+Cta43EG pygduRs7kati+CPP0b7zs6YnSni26glzCIZ1xxyxHS3WCvEwKuHnIWw2+ykG2iRS2W7y guE5qVJY2QyLTstthMwwI8yS7fFLEYwsvVKQcCdLBHkHN3G9GeFgm3pezUh46KUo0e4N fma3KipXecCBrAx6Me9uWgXAN9PzqOUw+KzKcieNdNtfsrVf2NfHyqHayonsaa7clNAo 2kZCA7/mfinrDmZ1zd6RLavmIbUop/Cy3w0NEWHEh7iovgrS/VqNPp2TQjjO2d7m/pMI bwdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=kL25i8Zz9G4d7AUFP51OG9jU0cPZgNzUVGr5+p5yT3A=; b=tEyAtNaD2QsqF3wOq5VG773IYvn2GQ9KHG4EP0CTVOH+WFvCVyLQXzNhZmV4hTk2KE T+vlfzVvdoMytqmoRGPDN9eh6kQbaIlUekELC6Ncmzt9onkolSt7g6hKWOFJKPnIeqDa 1hJseH05F5STZ3t2SVM+xm0akqmLROJc8WAAeXHHU7urPC3GRTc9exjVB37iSKbpxdjY Ruopp0kCzwa1ww58/BplxfoZSd+vPe+5FqF+gAAJ/F2qilCrD04IUz8hEDCBCNJ88mDo lnd9dCYBoJ/o/2MSyUNgqSCYTUMKrOn9ILALTlQt+CPbSBSBTFHqKV24OAU8g++4MaXk Xubw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=EZRAxdpo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x94si515986ede.62.2021.02.16.19.42.59; Tue, 16 Feb 2021 19:43:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=EZRAxdpo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbhBQDiu (ORCPT + 99 others); Tue, 16 Feb 2021 22:38:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbhBQDit (ORCPT ); Tue, 16 Feb 2021 22:38:49 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E441C061574 for ; Tue, 16 Feb 2021 19:38:09 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id n1so4432911edv.2 for ; Tue, 16 Feb 2021 19:38:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kL25i8Zz9G4d7AUFP51OG9jU0cPZgNzUVGr5+p5yT3A=; b=EZRAxdpojciOJtQmt+mWxk42W5j54FKU6esBNiyrMLkROt4kVy4rnatzjpn6EozfTs kVoJSAXlWtceQ0iWkT6OBSH4PdLxdnXfRDS6YWOsrGGA9yNKhUN3Q+s0BbqTi7obE9iF QaN3tCCpXd0dJhZrWt0A3xBdjGkaA4r4f1SXZygROYxP2Z3MJc/ip0GGC+EmN2nJr3MY MEkwjmobcosipCuOO/9yB/8L4a4DKUNIg9V2wPJx0KlbADUMWAFwBwTJ3fwzBOFlGcI2 m7MlH43LPwpIz9S1l7g+PaBfSXCV6mMJTRFvQ3NgDHRLHcxbVB/BKrIBNFN2ETAc22PK khbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kL25i8Zz9G4d7AUFP51OG9jU0cPZgNzUVGr5+p5yT3A=; b=fDUYT0I2Y7e6bXo0H1RPplpIH632ONwm/T2M8ZO9ny/oyrpvfGMIs5m9T3IRltRjOC omb4a7Zxctv6HQqeLRZ78mZVC1tFVb92b5K9U1Dql4EEqxnj8hb4c2/u9t4i1Y21iBla M8VKNsHGH1XWj6AwVRrxTZqvwiaqzeXxyJhvzcVvuMjRF+mtDA6fNuLe2WGTMWL0eL9j /DoGttG0gMOQ2QXtGxkFxT0ICOMP6z6KKJtzZU6t9EpZkBcw0H5epgVYTJYScHM42Y2A I2GfKGVrMIx45AYyeC9noAtkEBQoYhv4QXODRdN77uvrYUzBq0gWK9xzwVfmfhfbgpfs fL+w== X-Gm-Message-State: AOAM533o+S7M/80EO331yya5vDBhaXnLhbpic1wf3CDpinhRx2ONOUQi D5JS4rfmbSUCCfxt12qd93pFm6bID/ZN2j1M9zoGWg== X-Received: by 2002:a05:6402:306c:: with SMTP id bs12mr24297164edb.348.1613533087806; Tue, 16 Feb 2021 19:38:07 -0800 (PST) MIME-Version: 1.0 References: <20210212171043.2136580-1-u.kleine-koenig@pengutronix.de> <20210212171043.2136580-2-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210212171043.2136580-2-u.kleine-koenig@pengutronix.de> From: Dan Williams Date: Tue, 16 Feb 2021 19:37:58 -0800 Message-ID: Subject: Re: [PATCH 2/2] libnvdimm: Make remove callback return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Greg Kroah-Hartman , kernel@pengutronix.de, linux-nvdimm , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2021 at 9:21 AM Uwe Kleine-K=C3=B6nig wrote: > > All drivers return 0 in their remove callback and the driver core ignores > the return value of nvdimm_bus_remove() anyhow. So simplify by changing > the driver remove callback to return void and return 0 unconditionally > to the upper layer. Looks good, thanks.