Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp6297330pxb; Wed, 17 Feb 2021 00:11:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJypIWDOn/+3zQ7ZZVYas1TLgMrt/Txsa7zich+PkIq55AhcWtPOnCL2wNoYpCFbH9l4gGS6 X-Received: by 2002:aa7:d849:: with SMTP id f9mr11690401eds.76.1613549518767; Wed, 17 Feb 2021 00:11:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613549518; cv=none; d=google.com; s=arc-20160816; b=BSA4AJRQG9Gpo+fqUiPorUoR6/w7yqlv2sCJeAWekwGedMSzwJYwXMCcx0CeuNO/QU bgDaJPqHJXmY7ZSSsW54vJSYDpZcrYYEXen0rxrTqQH9SobXeg4VoWUyw1zwUNPDuuyQ kRLvVLiHGbQbYQFgwjJqf/cCJGAf0oKQsD6JwGk5nAYwOROgpqypayB5M/Zs0bsKy4o0 +rK+QsdxESkckeICRjkaidcFvaWy7jgD7lK1Uggw41wViMEgUvWmQTMNRPgTlmvCZ6nO 0JQGh3LUM+ZPK5y4spamCL6w8JJeKz96bT9s+rO6i6ooe4o3iJTWOLm1Ht/vAp0pNpbM +pnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ty5uD9bOV7o6D/btyVhiAA2LWIOfja8bfPucvyqfM7w=; b=VDBzh0jy08Sm3yAwAKr9+bsvapK5ZQWFyJvhREBDKEabgf5uaQ3pu4nW8d1nQ0ubvs bQGizO8a2DZme7WslElAy1F+TgzTJf4m5WiCvMCsIIANtAv7HMCNxnJBICv3eV5ek2Q4 ZNl7AjPe1CbG/NRkLRUJonnqWEKtP4NpgEBaGifsIYPvbnuxIvayL9DOeYGNR5FTJSB6 dNqRS0crD98L1F1VjP0LMfTqCfvD5ynM1VRlr4qUxE8WooL5eQOficSlA6yv3IMw8d8c FJjfEpYMNdGGQkYUt7gJSPr6SCzdU2F6O3DY1sdG3Ihgkp4jW61+JoYypeLFiNEN4L2t WU5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a25si782907edt.342.2021.02.17.00.11.36; Wed, 17 Feb 2021 00:11:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231737AbhBQII0 (ORCPT + 99 others); Wed, 17 Feb 2021 03:08:26 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:53080 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231758AbhBQIEb (ORCPT ); Wed, 17 Feb 2021 03:04:31 -0500 Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:4cb:a870:fd6e:12cd:95d7:3350]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 506761F45040; Wed, 17 Feb 2021 08:03:45 +0000 (GMT) From: Benjamin Gaignard To: ezequiel@collabora.com, p.zabel@pengutronix.de, mchehab@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@siol.net, krzk@kernel.org, shengjiu.wang@nxp.com, adrian.ratiu@collabora.com, aisheng.dong@nxp.com, peng.fan@nxp.com, Anson.Huang@nxp.com, hverkuil-cisco@xs4all.nl Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, kernel@collabora.com, Benjamin Gaignard Subject: [PATCH v1 06/18] media: hantro: Make sure that ctx->codex_ops is set Date: Wed, 17 Feb 2021 09:02:54 +0100 Message-Id: <20210217080306.157876-7-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210217080306.157876-1-benjamin.gaignard@collabora.com> References: <20210217080306.157876-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not try to call ctx->codec_ops->done if ctx->codec_ops is not set. Signed-off-by: Benjamin Gaignard Signed-off-by: Ezequiel Garcia Signed-off-by: Adrian Ratiu --- drivers/staging/media/hantro/hantro_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c index 0d58209fc55c..0570047c7fa0 100644 --- a/drivers/staging/media/hantro/hantro_drv.c +++ b/drivers/staging/media/hantro/hantro_drv.c @@ -93,7 +93,8 @@ void hantro_irq_done(struct hantro_dev *vpu, * and will take care of finishing the job. */ if (cancel_delayed_work(&vpu->watchdog_work)) { - if (result == VB2_BUF_STATE_DONE && ctx->codec_ops->done) + if (result == VB2_BUF_STATE_DONE && + ctx->codec_ops && ctx->codec_ops->done) ctx->codec_ops->done(ctx); hantro_job_finish(vpu, ctx, result); } -- 2.25.1