Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp6434931pxb; Wed, 17 Feb 2021 04:39:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxls+i286l9yYn8l2UZzDacG0KihLoWL86gjk/Mv55YLFtiKPJ1Lr/vSS3qiBMt7fzczQOM X-Received: by 2002:a05:6402:19:: with SMTP id d25mr25569583edu.71.1613565599692; Wed, 17 Feb 2021 04:39:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613565599; cv=none; d=google.com; s=arc-20160816; b=LYA0StpslqUfbs82CiZbdG9dsb7bEhBX7mTmMY2YBvnvBMPU3E06HhB5LJHEcUR0+p BvHwbt3PZfAcro6qE8aJAgZ8DXHehP3oW7kAodFjzh0jXSP/QaHWWby5vSBJCq57wCN8 /SGUqhBT9NYgIEOY3sU3e/K/14B76ZL9XAp0beTbFgzPlxnTEkscCeWWjx8aiC7sHv6Q drSpbzXoeeyPfoR0jt07ekqkWs22yVqYH5rw0br0K7FACQ8hd9UHd9IQn53PJMBmgMaH Onb3y2qQnW+dRkTGTQcJvEtoH4dLtjPsYZFU/S38UgY4wWlBAuQ1pQY+bmnrR0anYCCI gxbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JU9xqyDz+/JZ1pv9CUV7jElgPp7ezMbvPiq81Zym9Z8=; b=W1sgUKjnXHUfTSs4AhLEhZ5AEYiL0bx7x7ORtuVXyQPArwbW/YlWU6xyldzooucAVZ U3II7auebtyCXnoTgDH4ERtdo7CnnMNkbCHGZibSGZvvMmuWACTZM9jFO9CQk4dzhYT8 yDToEgfGDKTe5ZF9lmWIkQ8XeL2fXdLk1x2D+xH7wvDZbTrJnOVuNcsBg0pmZJHF9lTM DU+gHNLt7zmhEe6af8xLoIzb5vu1eQ9AAMxDKzhGi36zlslxFOJPCWvL+Kuc1vtivJwF wmICM8DvwA5z4TvptfS7OWWrwfM+DkbHFJjzmTS9xcN2pb0nm91uYe8ccmn6FqO31TPn aM4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BanYymEO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si1391554ejb.687.2021.02.17.04.39.35; Wed, 17 Feb 2021 04:39:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BanYymEO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232733AbhBQMff (ORCPT + 99 others); Wed, 17 Feb 2021 07:35:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41109 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232660AbhBQMdw (ORCPT ); Wed, 17 Feb 2021 07:33:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613565145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JU9xqyDz+/JZ1pv9CUV7jElgPp7ezMbvPiq81Zym9Z8=; b=BanYymEOXWCTb4uOcmgS9seDxbL29WZwi0+IhZlvFSQOruhGa++/gj3tOg+l3q8rnlLw3g WMlTPPwloWarp3hL5Tacuw1LIDb0LDik2ev76mVv5hI0YpWG1+RNEU1vgV5m6nen4BV1RL BJArn3duUybjP9N4fJRHzuRcVv02UXk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-uUYTIYitMOy6UjmdQVRIAw-1; Wed, 17 Feb 2021 07:32:24 -0500 X-MC-Unique: uUYTIYitMOy6UjmdQVRIAw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD3C580196C; Wed, 17 Feb 2021 12:32:22 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-114-184.ams2.redhat.com [10.36.114.184]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D32310027A5; Wed, 17 Feb 2021 12:32:19 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9127D18003B7; Wed, 17 Feb 2021 13:32:14 +0100 (CET) From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: Gerd Hoffmann , Dave Airlie , David Airlie , Daniel Vetter , virtualization@lists.linux-foundation.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), spice-devel@lists.freedesktop.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 06/11] drm/qxl: add qxl_bo_vmap/qxl_bo_vunmap Date: Wed, 17 Feb 2021 13:32:08 +0100 Message-Id: <20210217123213.2199186-7-kraxel@redhat.com> In-Reply-To: <20210217123213.2199186-1-kraxel@redhat.com> References: <20210217123213.2199186-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add vmap/vunmap variants which reserve (and pin) the bo. They can be used in case the caller doesn't hold a reservation for the bo. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_object.h | 2 ++ drivers/gpu/drm/qxl/qxl_object.c | 36 ++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_object.h b/drivers/gpu/drm/qxl/qxl_object.h index 2495e5cdf353..ee9c29de4d3d 100644 --- a/drivers/gpu/drm/qxl/qxl_object.h +++ b/drivers/gpu/drm/qxl/qxl_object.h @@ -64,7 +64,9 @@ extern int qxl_bo_create(struct qxl_device *qdev, u32 priority, struct qxl_surface *surf, struct qxl_bo **bo_ptr); +int qxl_bo_vmap(struct qxl_bo *bo, struct dma_buf_map *map); int qxl_bo_vmap_locked(struct qxl_bo *bo, struct dma_buf_map *map); +int qxl_bo_vunmap(struct qxl_bo *bo); void qxl_bo_vunmap_locked(struct qxl_bo *bo); void *qxl_bo_kmap_atomic_page(struct qxl_device *qdev, struct qxl_bo *bo, int page_offset); void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev, struct qxl_bo *bo, void *map); diff --git a/drivers/gpu/drm/qxl/qxl_object.c b/drivers/gpu/drm/qxl/qxl_object.c index f4a015381a7f..82c3bf195ad6 100644 --- a/drivers/gpu/drm/qxl/qxl_object.c +++ b/drivers/gpu/drm/qxl/qxl_object.c @@ -29,6 +29,9 @@ #include "qxl_drv.h" #include "qxl_object.h" +static int __qxl_bo_pin(struct qxl_bo *bo); +static void __qxl_bo_unpin(struct qxl_bo *bo); + static void qxl_ttm_bo_destroy(struct ttm_buffer_object *tbo) { struct qxl_bo *bo; @@ -179,6 +182,25 @@ int qxl_bo_vmap_locked(struct qxl_bo *bo, struct dma_buf_map *map) return 0; } +int qxl_bo_vmap(struct qxl_bo *bo, struct dma_buf_map *map) +{ + int r; + + r = qxl_bo_reserve(bo); + if (r) + return r; + + r = __qxl_bo_pin(bo); + if (r) { + qxl_bo_unreserve(bo); + return r; + } + + r = qxl_bo_vmap_locked(bo, map); + qxl_bo_unreserve(bo); + return r; +} + void *qxl_bo_kmap_atomic_page(struct qxl_device *qdev, struct qxl_bo *bo, int page_offset) { @@ -223,6 +245,20 @@ void qxl_bo_vunmap_locked(struct qxl_bo *bo) ttm_bo_vunmap(&bo->tbo, &bo->map); } +int qxl_bo_vunmap(struct qxl_bo *bo) +{ + int r; + + r = qxl_bo_reserve(bo); + if (r) + return r; + + qxl_bo_vunmap_locked(bo); + __qxl_bo_unpin(bo); + qxl_bo_unreserve(bo); + return 0; +} + void qxl_bo_kunmap_atomic_page(struct qxl_device *qdev, struct qxl_bo *bo, void *pmap) { -- 2.29.2