Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 17 Feb 2021 16:33:18 +0100
From:   Michal Hocko <mhocko@suse.com>
To:     Oscar Salvador <osalvador@suse.de>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        David Hildenbrand <david@redhat.com>,
        Muchun Song <songmuchun@bytedance.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: Make alloc_contig_range handle in-use hugetlb
 pages
Message-ID: <YC03Pmb6/ePK2UPn@dhcp22.suse.cz>
References: <20210217100816.28860-1-osalvador@suse.de>
 <20210217100816.28860-3-osalvador@suse.de>
 <YC0xAmuJLJ6yNbCD@dhcp22.suse.cz>
 <66332742e9f44697212f25061790291e@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <66332742e9f44697212f25061790291e@suse.de>
Precedence: bulk

On Wed 17-02-21 16:27:27, Oscar Salvador wrote:
> On 2021-02-17 16:06, Michal Hocko wrote:
> > I do not follow. You have successfully isolated huge pages so why don't
> > you add that page to the migratepages list to be migrated?
> 
> It is added. Note that I pass de list (cc->migratepages) to
> isolate_or_dissolve_huge_page().
> It is done this way because we have to pass the list to isolate_huge_page()
> directly.
> That is why I jump to isolate_success_no_list instead of isolate_sucess.
> 
> I know it is subtle, but I could not come up with a better name at that
> time.

OK, I have missed that. Maybe just extend the comment. 

	/*
	 * Hugepage was succesfully isolated and on the tmigratepages
	 * list 
	 */
-- 
Michal Hocko
SUSE Labs