Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 17 Feb 2021 17:27:18 +0100
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Rui Salvaterra <rsalvaterra@gmail.com>,
        gregory.clement@bootlin.com, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: turris-omnia: fix hardware buffer management
Message-ID: <20210217172718.6fdf412e@kernel.org>
In-Reply-To: <YC1CuWnLQju7wMl2@lunn.ch>
References: <20210217153038.1068170-1-rsalvaterra@gmail.com>
        <YC1CuWnLQju7wMl2@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 17 Feb 2021 17:22:17 +0100
Andrew Lunn <andrew@lunn.ch> wrote:

> On Wed, Feb 17, 2021 at 03:30:38PM +0000, Rui Salvaterra wrote:
> > Hardware buffer management has never worked on the Turris Omnia, as the
> > required MBus window hadn't been reserved. Fix thusly.  
> 
> Hi Rui
> 
> I don't know all the details for the MBus Windows...
> 
> Can this be set once in armada-385.dtsi ?
> 
> Did you check the other dts files. Do any others have the same
> problem?
> 
>     Andrew

armada-38x.dtsi defines only
  ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
for internal-regs.

It probably depends on how the mbus driver works.
If the mbus driver maps every window defined in ranges, regardless
whether they are used, then we do not want to put all windows in .dtsi
file.

Marek