Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: schowdhu=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 17 Feb 2021 18:40:22 +0530
From:   schowdhu@codeaurora.org
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        Rajendra Nayak <rnayak@codeaurora.org>,
        Sibi Sankar <sibis@codeaurora.org>,
        Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Subject: Re: [PATCH V0 2/6] arm64: dts: qcom: sm8150: Add Data Capture and
 Compare(DCC) support node
In-Reply-To: <20210217110331.GS2774@vkoul-mobl.Dlink>
References: <cover.1613541226.git.schowdhu@codeaurora.org>
 <893022aecd4ba354adb57bd463206dd93fc19886.1613541226.git.schowdhu@codeaurora.org>
 <20210217110331.GS2774@vkoul-mobl.Dlink>
Message-ID: <10001950e73eb5e322fda6359103ebda@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

Hi,

Please find the replies inline.


On 2021-02-17 16:33, Vinod Koul wrote:
> On 17-02-21, 12:18, Souradeep Chowdhury wrote:
>> Add the DCC(Data Capture and Compare) device tree node entry along 
>> with
>> the addresses for register regions.
> 
> This should be last patch..

Ack

> 
>> 
>> Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi 
>> b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> index e5bb17b..3198bd3 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> @@ -654,6 +654,13 @@
>>  			interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
>>  		};
>> 
>> +		dcc@010a2000{
> 
> no leading zero here and space before {

Ack

> 
>> +			compatible = "qcom,sm8150-dcc", "qcom,dcc";
>> +			reg = <0x0 0x010a2000 0x0 0x1000>,
>> +				<0x0 0x010ad000 0x0 0x3000>;
> 
> pls align this to preceding line

Ack

> 
>> +			reg-names = "dcc-base", "dcc-ram-base";
>> +		};
>> +
>>  		ufs_mem_hc: ufshc@1d84000 {
>>  			compatible = "qcom,sm8150-ufshc", "qcom,ufshc",
>>  				     "jedec,ufs-2.0";
>> --
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
>> member
>> of Code Aurora Forum, hosted by The Linux Foundation