Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp6669773pxb; Wed, 17 Feb 2021 10:11:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJyq9FWfsEWmDe0aQr9i4/u8gd6JLTP4Qtqiwa6AnDEf2z0XKE6CWogVb/IOVkw1zX19GrKp X-Received: by 2002:a17:906:6b1b:: with SMTP id q27mr207128ejr.508.1613585473944; Wed, 17 Feb 2021 10:11:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613585473; cv=none; d=google.com; s=arc-20160816; b=xiI2I4Z2yvxcOo3oKjwiMw/wVG8RvvLRQEWyMxtw8EEPBXXqh/X0iX+UFNRpHLL6Nw lgeKKOi/0rcfzx+jXm22OWHxRaELURqH5zYgWxyMt07mD7nDOGB0F/dKzdiUwF7Vbjgr ElAV6SNPSl34ctU4ssDesUGNmYpRefP6+IRxMY5Gogspv0QbAycK7qu5DTdYK1RsDiVx DTu8tke/y3/EG6f+xo57Vz0ccgTJCXVccr0mz2NLsOF4pv5Ij7Aukh4wTnh0BhgmLZwK PoNkOyV2aTa8mhGSRtim4cWQfWMJYOPncRCV8We4ALO/f7zIhs3+ncR8bImPo87qlncv qzRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JNTEdztdkE1lCtq+NwSCN/V35SWPjHdUptK15zPgB14=; b=QKg+eOhjg83oH2XL2fO3lnKg9gmejfiyujXVzg1UPrqMygBIsBwawchuHBjqo7GvQN SsdfJV+IXN1MTigmCI209jTzfK02jX2ljCL3Hng8IHhZPp/nSGEW2Sa9gpwy7kG9InUu toN1cXalH+VZHKmaTiauJG7cRmQoMWYbNejFg/midIlBLB79fN6bHfQE3BTtt6emSgvY uyJIYbTnaiHsr9RAA6KxLD02bclUGvMiKfZuUDmV1nLYZ79W3JITEXtT6LyNRgrM+tgn KUx+9jezbO0LwS2O3STU/TYl21WYFkbTxFD76//XOCLGCT31EuMgvPiBofqudlHyz5ml E5uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o5wafKTd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q12si2011208ejs.148.2021.02.17.10.10.48; Wed, 17 Feb 2021 10:11:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=o5wafKTd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233345AbhBQOSj (ORCPT + 99 others); Wed, 17 Feb 2021 09:18:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:43050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232371AbhBQOSf (ORCPT ); Wed, 17 Feb 2021 09:18:35 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BD17C64DBD; Wed, 17 Feb 2021 14:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613571475; bh=9DtE28FgJnN9z9xq9OPPtCLnloyzssm4m4fGCOYg9Bk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o5wafKTdgY0WWFUxF9kARDCaFzQRev6VAoYAMmpGwvR8PuDZA8Jh/CUf535/3GUqn TAP2/M2hR268xiAc/buBQv018xNaT5+1dS+1AJx5IqLaIljMtcvsBKOjquwr+RC1vZ ynRk2VI7sq9l8nXGn1V0d2PwfUtc2SJKbCIksXgg= Date: Wed, 17 Feb 2021 15:17:52 +0100 From: Greg Kroah-Hartman To: Takashi Iwai Cc: Luis Chamberlain , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 1/4] firmware: Add the support for ZSTD-compressed firmware files Message-ID: References: <20210127154939.13288-1-tiwai@suse.de> <20210127154939.13288-2-tiwai@suse.de> <20210217132419.GN4332@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2021 at 02:34:34PM +0100, Takashi Iwai wrote: > On Wed, 17 Feb 2021 14:24:19 +0100, > Luis Chamberlain wrote: > > > > On Wed, Jan 27, 2021 at 04:49:36PM +0100, Takashi Iwai wrote: > > > Due to the popular demands on ZSTD, here is a patch to add a support > > > of ZSTD-compressed firmware files via the direct firmware loader. > > > It's just like XZ-compressed file support, providing a decompressor > > > with ZSTD. Since ZSTD API can give the decompression size beforehand, > > > the code is even simpler than XZ. > > > > > > Signed-off-by: Takashi Iwai > > > > It also occurs to me that having a simple like #define HAVE_FIRMWARE_COMPRESS_ZSTD > > on include/linux/firmware.h would enable userspace to be aware (if they > > have kernel sources) to determine if the kernels supports this format. > > Extending that idea, we might want to have a sysfs entry showing the > supported formats instead? This will allow to judge dynamically. What could userspace do with that information?