Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 17 Feb 2021 20:02:24 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     Michael Walle <michael@walle.cc>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de
Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain
In-Reply-To: <20210217195717.13727-1-michael@walle.cc>
References: <YCvYV53ZdzQSWY6w@kroah.com>
 <20210217195717.13727-1-michael@walle.cc>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <4e4d0479b935e60a53f75ef534086476@kernel.org>
Precedence: bulk

On 2021-02-17 19:57, Michael Walle wrote:
> Hi Greg,
> 
>> There's no need to keep around a dentry pointer to a simple file that
>> debugfs itself can look up when we need to remove it from the system.
>> So simplify the code by deleting the variable and cleaning up the 
>> logic
>> around the debugfs file.
> 
> This will generate the following oops on my board (arm64,
> freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts). In debugfs_lookup()
> debugfs_mount is NULL.

That's odd. I gave it a go yesterday, and nothing blew up.
Which makes me wonder whether I had the debug stuff enabled
the first place...

I've dropped the patch from -next for now until I figure it out
(probably tomorrow).

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...