Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp6786140pxb; Wed, 17 Feb 2021 13:27:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwX9Fkz0PfKFjsYTU9oUf6jxiZWQWjHkW+49SrRr+o+8Ts+9uUrlMHUf2a50BMM9mV7M5fU X-Received: by 2002:a17:906:5846:: with SMTP id h6mr831186ejs.521.1613597253505; Wed, 17 Feb 2021 13:27:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613597253; cv=none; d=google.com; s=arc-20160816; b=YLpCriyKeUxjfqEmgJ3UwQIcfcDOd1Vj/nwITBcxty15wtql3dFMUbJCd4j3HqcwUT Rt1nvijdRv7r5rfdDYifW2Yx2jKJKr24W6NxWX5j27hq+QCHx0hTv6TpP9GwmvNS+KXB Au/Jj3s2x4hid7c+ELPqo0BfibN7QyHTlEf9Xk+ChZjFem+VLEZB6ZxUyUW3tRdCcjtc iOVVuoqjbGk9fcR4BHTfx/T88MZMh+xbL8EHp0gQ1GtJxaxiinTaQ3CX6pbWFxbBD1zX 57qTbnWDcC5Riskuf2m1MgsGEV23JH6l9WgXlqBc+JoNaYCWUcXp7gp9Zx5hWVNXXzQo Jy9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:dkim-signature:dkim-filter:date; bh=9hWwSvImwpCddJlz6sxGENyLsZ5DxkEBmFxdADy8W0Q=; b=oEKU+Fq5hV+Szkv2cFdgpmc3FBpQhDl7uC+y68lnEK8hQIGuqLYjggQoLVD/+AvHPt BZrcQtDyhArcrZJk9zRmlhuzcvzkd6lNDWEMcrx+o0T/nPg2GDfc/6Lb1HKP0Ab8dKct pi2S3lGz8f1lo6DP0RlETbIHYIYe7hPCQi6ZwOb0XnfKYgx6opCH5PpggvE4xxEl96V0 GHmpCnVLei/9wubig5KA/o3pwjjcr1rttmB5MbjzlLpfEsniJ0Rh5//Uz5RIh0+USK/b ixqkE5BGLzYpw7s1o979dw5RvuOFVHy59rEK4ljHmrDMN8XmrvuQnlbu+EolBKYmTqxG /eSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@innovation.ch header.s=default header.b=OGm8UHNh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=innovation.ch Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si2737767ejd.310.2021.02.17.13.27.08; Wed, 17 Feb 2021 13:27:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@innovation.ch header.s=default header.b=OGm8UHNh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=innovation.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233073AbhBQUxt (ORCPT + 99 others); Wed, 17 Feb 2021 15:53:49 -0500 Received: from chill.innovation.ch ([216.218.245.220]:46188 "EHLO chill.innovation.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232243AbhBQUxj (ORCPT ); Wed, 17 Feb 2021 15:53:39 -0500 Date: Wed, 17 Feb 2021 12:52:57 -0800 DKIM-Filter: OpenDKIM Filter v2.10.3 chill.innovation.ch 6AB8D6413BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=innovation.ch; s=default; t=1613595177; bh=9hWwSvImwpCddJlz6sxGENyLsZ5DxkEBmFxdADy8W0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OGm8UHNhmxezVl+mdk1IfFhbUpmFzR0PRxDo3MjSVfsmo4Yw6pRsDOT3AJuqX9wQP ICTbAC7GsLGQ4nU2XP4R8mLomz0FDZVng8Isbk8nmnGrO6uqa3noY1PHAuJ6XL+Lo1 llJcHNl2TCpcsLJUJ++6+wbl8P1mM92IkXD7KSFFMB3kkjEPGlXaGCkJf0IWoEob5s Xk5tBDinYPFEazrZuu1kj7daa0szyp5gwHDFtd8CphmQYQvw8hj1Uvd/djAqw2vPAh LaUnFEzAxqp6L+puFRVi+OSRHJS9gukxOhJN26Ikjn5yP9Wym6fBIbUCsiP8+BhcSq 3kA6AXG6O62cQ== From: "Life is hard, and then you die" To: Dmitry Torokhov Cc: "Gustavo A. R. Silva" , Sergiu Cuciurean , Lee Jones , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Input: applespi: Add trace_event module param for early tracing. Message-ID: <20210217205257.GB25685@innovation.ch> References: <20210217190718.11035-1-ronald@innovation.ch> <20210217190718.11035-3-ronald@innovation.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Wed, Feb 17, 2021 at 12:26:18PM -0800, Dmitry Torokhov wrote: > > On Wed, Feb 17, 2021 at 11:07:18AM -0800, Ronald Tschal?r wrote: > > The problem is that tracing can't be set via sysfs until the module is > > loaded, at which point the keyboard and trackpad initialization commands > > have already been run and hence tracing can't be used to debug problems > > here. > > > > Adding this param allows tracing to be enabled for messages sent and > > received during module probing. It takes comma-separated list of events, > > e.g. > > > > trace_event=applespi_tp_ini_cmd,applespi_bad_crc > > You can unbind and rebind a device to a driver via sysfs as many times > as needed (see bind and unbind driver sysfs attributes), so I believe Hmm, I'm going to have to play with that a bit, but one place it still won't help I think is something we ran into in practise: init was failing during boot, but was successfull later on. Cheers, Ronald