Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp6787469pxb; Wed, 17 Feb 2021 13:30:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkjBFxgJKBt0lHCAUEMUtY480iDrG14l7eWwEuvnDCcSz+N0gp19T9I0V2JxxyNRrzYWyo X-Received: by 2002:a17:906:488:: with SMTP id f8mr834905eja.311.1613597403869; Wed, 17 Feb 2021 13:30:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613597403; cv=none; d=google.com; s=arc-20160816; b=J0to4QVyrMREYIZeAGkiOfSr/iQlJOVuFvzcsC4CzLaeZABuQCAVF/iwFI/SChuGMC pXP7/V+J+nujgX+ACdqEZBy01E7RQYsdNnZ3XtwvfZeQKMGd6WBCD4Nw0eLcR1LyYNiI RTyA5d+rnWW2QqMNmyWyIRLfCz6rcR4xoRQm83yXsF/IwLWyKkakgXIMf0RP7k+Sh9Ni MoZP9Hff62wKfwaQ6ePZLNw2mlNOn0tKPCsGD3kBgliqmxem0MStBYBivDd82gJPoMR7 Goo3qwL6dLmA4tU33rx45cD6r20+pvLRxJxKf/CGahlVa6c/NlP6oCXBXPg2zZkhHgjy OC8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=sQzaNxAid9QvqVYhihsfh2vWMCoJ27PcKGw8kt1g66I=; b=xgKIIQDlNRW50qwCh2+CNXeHgMVdAzbE07t+kz+N7oREWTMTLHue5lEqNqjpr4uTj6 hOnRPQKZgaxdlYhtPxSvtBklYUOR6BeymZ4/Bbu1f9TE4RSvpLkIFXPsxeERn3kudWgz CVqFYudb1ghMcSuKuOEMsrzjavSTpIU/RAGsKwJRPwaRSJ5bqVFgXMbMy7eopJrUiyrq j4Cp08LIgi4DeZo/4BBJKuK2ZQpBV68UAIGQOX8N0+YByopzPpUGBXu5Vf9RutJF3fKx l+17CMChQaHVSGuaDHUUXYx1aEsYTeioq9RWbYpHesHYSBKBMsSPaRp0xwUAv338EYHI KVIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p0QwrOct; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m14si2160151ejn.267.2021.02.17.13.29.39; Wed, 17 Feb 2021 13:30:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=p0QwrOct; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232965AbhBQVXM (ORCPT + 99 others); Wed, 17 Feb 2021 16:23:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233744AbhBQVWs (ORCPT ); Wed, 17 Feb 2021 16:22:48 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDAC5C0613D6; Wed, 17 Feb 2021 13:22:08 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id fa16so59383pjb.1; Wed, 17 Feb 2021 13:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sQzaNxAid9QvqVYhihsfh2vWMCoJ27PcKGw8kt1g66I=; b=p0QwrOctwd52hexap6KCKB3coo8XhqEMui5DoM+5kapBOCgvyAp7ekJdpeCpkuv7IO Kyq/cmtvDejQPhs7UFTwVYQGBE1U+C4HUmKE7W4yGgYjjD5Wv4ozQ7D+kSnc5LrVYTeW NvA45IpZf95mwZtcplJBAMyAqh2ftR73lmDJka9nasDdXC2zXNSRlklCdPXnZPoLUVrg 4VTC1SsTKN4i88U4NYVKpB8ikdmEKhy2ZOLoMyyQFCrbBjzSTISK2fAdTTn0tGMC692s Ik9IHq3dovW92AIGU47FexYjZGQyAAwP5VTWHbyxBq2BdjDtKjXIzIF+LlwyQulVCA0N 0a/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=sQzaNxAid9QvqVYhihsfh2vWMCoJ27PcKGw8kt1g66I=; b=H9U/XrgKaERkHzKXDIpnPUAYtNrQPfbJrFnRnKu5lTGYnUv3TMiIMDJSqldV4CmeYD wYL9nGouoy9G+ZPKU3ZO/EWjWqg6rv+TZut4VqnpJkZgfOnq7wrQJa70CrPtcwYE7hdo bC87v++sBSNOCLYWAF59Mn0AhHA7o0J8SE5/BAHkIFENsR52h8ScGNxk6zZfAD063npi O8CmMj0t9VIgUBsAkr1SEliNuF7qAVersqw/T1lWZ1z009vi1SqT7YEzrVumjEaaKxP7 Gm8i5lpD3HAeJzfeiWdXbJDWtxA3CsTwHalARa92KqOnogIgyBDjCpVKH6DvMnuiR8xb gkyg== X-Gm-Message-State: AOAM5334LeXS9907V8Ci4FF34CCCiSIw/REipBnqsERwmFcCg0TM56mT xC5PfFfrO1f8Xt5v9zeBEO0= X-Received: by 2002:a17:902:f54e:b029:e3:5af0:d98f with SMTP id h14-20020a170902f54eb02900e35af0d98fmr920942plf.5.1613596928463; Wed, 17 Feb 2021 13:22:08 -0800 (PST) Received: from google.com ([2620:15c:211:201:157d:8a19:5427:ea9e]) by smtp.gmail.com with ESMTPSA id 184sm3475254pgi.92.2021.02.17.13.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 13:22:07 -0800 (PST) Sender: Minchan Kim Date: Wed, 17 Feb 2021 13:22:05 -0800 From: Minchan Kim To: Matthew Wilcox Cc: Michal Hocko , Andrew Morton , linux-mm , LKML , cgoldswo@codeaurora.org, linux-fsdevel@vger.kernel.org, david@redhat.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, joaodias@google.com Subject: Re: [RFC 1/2] mm: disable LRU pagevec during the migration temporarily Message-ID: References: <20210216170348.1513483-1-minchan@kernel.org> <20210217211143.GN2858050@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210217211143.GN2858050@casper.infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2021 at 09:11:43PM +0000, Matthew Wilcox wrote: > On Wed, Feb 17, 2021 at 12:51:25PM -0800, Minchan Kim wrote: > > I'd like to avoid atomic operation if we could. > > Why do you think that the spinlock is better? > Michal suggested atomic_inc in writeside and atomic_read in readside. I wanted to avoid atomic operation in readside path. You are suggesting atomic for writeside and just read(not atomic_read) in readside?