Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] IMA: support for duplicate data measurement
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     tyhicks@linux.microsoft.com, sashal@kernel.org, jmorris@namei.org,
        nramas@linux.microsoft.com, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210217024649.23405-1-tusharsu@linux.microsoft.com>
 <ab197aa9719b4218ab497b55f0bc78a0dadc83dd.camel@linux.ibm.com>
From:   Tushar Sugandhi <tusharsu@linux.microsoft.com>
Message-ID: <5236e03f-9be4-f7f3-ec6c-29f00c16dc18@linux.microsoft.com>
Date:   Wed, 17 Feb 2021 10:53:40 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <ab197aa9719b4218ab497b55f0bc78a0dadc83dd.camel@linux.ibm.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Thanks for the feedback Mimi.
Appreciate it.

On 2021-02-17 7:03 a.m., Mimi Zohar wrote:
> Hi Tushar,
> 
> The Subject line could be improved.  Perhaps something like - "IMA:
> support for duplicate measurement records"
> 
Will do.

> On Tue, 2021-02-16 at 18:46 -0800, Tushar Sugandhi wrote:
>> IMA does not measure duplicate data since TPM extend is a very expensive
>> operation.  However, in some cases, the measurement of duplicate data
>> is necessary to accurately determine the current state of the system.
>> Eg, SELinux state changing from 'audit', to 'enforcing', and back to
>> 'audit' again.  In this example, currently, IMA will not measure the
>> last state change to 'audit'.  This limits the ability of attestation
>> services to accurately determine the current state of the measurements
>> on the system.
> 
> This patch description is written from your specific usecase
> perspective, but it impacts file and buffer data measurements as well,
> not only critical data measurements.  In all of these situations, with
> this patch a new measurement record is added/appended to the
> measurement list.  Please re-write the patch description making it more
> generic.
> 
> For example, I would start with something like, "IMA does not include
> duplicate file, buffer or critical data measurement records ..."
> 
Agreed.
I will generalize the description further and send the v3 for review.

Thanks,
Tushar

> thanks,
> 
> Mimi
> 
>>
>> Update ima_add_template_entry() to support measurement of duplicate
>> data, driven by a Kconfig option - IMA_DISABLE_HTABLE.
>>
>> Signed-off-by: Tushar Sugandhi <tusharsu@linux.microsoft.com>